Skip to content

feat: add IFU functionality#199

Closed
civsiv wants to merge 6 commits intomasterfrom
feature/ifus
Closed

feat: add IFU functionality#199
civsiv wants to merge 6 commits intomasterfrom
feature/ifus

Conversation

@civsiv
Copy link
Copy Markdown
Contributor

@civsiv civsiv commented Jun 13, 2023

This PR adds IndividualFacilityUse functionality to Server.NET.

In order to fully finish off this PR the following needs to happen (apart from the review comments below):

  1. an appsettings.ifu.json file needs to be added to this PR (or based on the comment below re default FU vs IFU behaviour, an appsettings.fuNoIfu.json)
  2. In Test Suite, an env file needs to be added to run Test Suite in IFU mode
  3. This branch needs to be renamed to be coverage/ifus so that the Test Suite branch in 2 run tests against this branch
  4. Add individual facility uses to the Github Actions test matrix so that every CI run also runs IFU tests

Copy link
Copy Markdown
Contributor

@nickevansuk nickevansuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to suggested changes previously discussed

Comment thread Examples/BookingSystem.AspNetCore/Settings/EngineConfig.cs
Comment thread Examples/BookingSystem.AspNetCore/Settings/EngineConfig.cs
Comment thread Examples/BookingSystem.AspNetCore/Settings/EngineConfig.cs
Comment thread Examples/BookingSystem.AspNetCore/Settings/EngineConfig.cs
Comment thread Examples/BookingSystem.AspNetCore/Stores/FacilityStore.cs
Comment thread Fakes/OpenActive.FakeDatabase.NET/Models/FacilityUseTable.cs Outdated
@lukehesluke
Copy link
Copy Markdown
Contributor

As mentioned here: #201 (comment), this IFU PR includes the changes from #201. So, if this IFUs PR gets merged first, please could the merger then close #201? Thanks

@nickevansuk
Copy link
Copy Markdown
Contributor

As per this PR's description, a new PR has been created #204 in order to rename the branch to coverage/ifus

@nickevansuk nickevansuk closed this Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants