Feature/remove remainingattendeecapacity from b#229
Merged
civsiv merged 2 commits intofeature/elaborate-todosfrom Apr 3, 2024
Merged
Feature/remove remainingattendeecapacity from b#229civsiv merged 2 commits intofeature/elaborate-todosfrom
civsiv merged 2 commits intofeature/elaborate-todosfrom
Conversation
lukehesluke
approved these changes
Apr 2, 2024
|
|
||
| public static void RemovePropertiesFromBookedOrderItem(IOrderItemContext ctx) | ||
| { | ||
| // Set RemainingAttendeeCapacity and MaximumAttendeeCapacity to null as the do not belong in the B and P responses. |
Contributor
There was a problem hiding this comment.
Suggested change
| // Set RemainingAttendeeCapacity and MaximumAttendeeCapacity to null as the do not belong in the B and P responses. | |
| // Set RemainingAttendeeCapacity and MaximumAttendeeCapacity to null as they do not belong in the B and P responses. |
civsiv
added a commit
that referenced
this pull request
Apr 4, 2024
* feat: elaborate TODOs * Feature/remove remainingattendeecapacity from b (#229) * feat: remove remainingAttendeeCapacity and maximumAttendeeCapacity from B response * remove from P response too * Update OpenActive.Server.NET/CustomBookingEngine/CustomBookingEngine.cs Co-authored-by: Luke Winship <luke.winship@gmail.com> * elaborate a todo --------- Co-authored-by: Luke Winship <luke.winship@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #228
Before:
After: