feat(go): iOS push notifications via Firebase Cloud Messaging#376
Merged
zomux merged 1 commit intoMay 12, 2026
Merged
Conversation
Adds the client half of the push-notification system whose backend shipped in PR openagents-org#375. Pairs the iPhone app with FCM so users receive banners for agent chat, @mentions, terminal status transitions, and errors when they're not actively looking at the affected chat. - project.yml: add Firebase iOS SDK (SPM) with FirebaseCore + FirebaseMessaging as iOS-only target dependencies; UIBackgroundModes remote-notification and aps-environment development entitlement. - AppDelegate.swift (iOS only): FirebaseApp.configure(), permission prompt on first launch, APNs↔FCM token bridging, foreground/banner delegate. Adopted via @UIApplicationDelegateAdaptor. - PushSink.swift: bridges UIKit AppDelegate ↔ SwiftUI router. Fans the FCM token out to every workspace in WorkspaceHistory on receipt, so notifications flow from any backend the user has connected to. - WorkspaceAPI.registerDeviceToken: POST /v1/devices/register. - GoogleService-Info.plist placeholder committed; replace with the real plist from the Firebase Console (openagentsweb project, bundle com.openagents.go) before TestFlight/App Store builds. Verified iOS Debug and macOS Debug builds.
|
@baryhuang is attempting to deploy a commit to the Raphael's projects Team on Vercel. A member of the Team first needs to authorize it. |
zomux
approved these changes
May 12, 2026
Contributor
zomux
left a comment
There was a problem hiding this comment.
Looks good! Clean Firebase/APNs integration with proper #if os(iOS) gating. Placeholder plist is appropriate — no secrets committed. Minor notes (non-blocking): AppDelegate is included in macOS target build phase (compiles to nothing, just noise), and aps-environment entitlement will need switching to production for release builds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Client half of the iOS push-notification system whose backend ships in #375. Pairs the iPhone app with FCM so users receive banners for agent chat, @mentions, terminal status transitions, and errors when they're not actively looking at the affected chat.
All push code is wrapped in `#if os(iOS)`; macOS deferred and continues to build clean.
Dependencies
Test plan