Skip to content

Run tests with PHP 8.5 and fix phpstan issue resolved by Symfony 7.4 #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GromNaN merged 1 commit into from
Dec 15, 2025
+5 −7
Merged

Run tests with PHP 8.5 and fix phpstan issue resolved by Symfony 7.4 #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,13 @@ jobs:
strategy:
fail-fast: true
matrix:
php: [8.2, 8.3, 8.4]
symfony: [^6.4, false]
php: [8.2, 8.3, 8.4, 8.5]
symfony: [false]
dependency: [stable]
include:
- { php: 8.2, symfony: ^6.4 , dependency: stable }
- { php: 8.4, symfony: ^7.4, dependency: highest }
- { php: 8.4, symfony: ^8.0, dependency: highest }
- { php: 8.4, symfony: false, dependency: highest }

env:
SYMFONY_REQUIRE: ${{ matrix.symfony }}
Expand Down
5 changes: 1 addition & 4 deletions src/OpenAIBundle.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
use OpenAI\Client;
use OpenAI\Contracts\ClientContract;
use OpenAI\Factory;
use Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition;
use Symfony\Component\Config\Definition\Configurator\DefinitionConfigurator;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
Expand All @@ -23,13 +22,11 @@ final class OpenAIBundle extends AbstractBundle
public function configure(DefinitionConfigurator $definition): void
{
$root = $definition->rootNode();
assert($root instanceof ArrayNodeDefinition);
$children = $root->children();
$children
->scalarNode('api_key')
->defaultValue('%env(OPENAI_API_KEY)%')
->info('OpenAI API Key used to authenticate with the OpenAI API')
->isRequired();
->info('OpenAI API Key used to authenticate with the OpenAI API');
$children
->scalarNode('organization')
->info('OpenAI API Organization used to authenticate with the OpenAI API')
Expand Down
Loading