pytorch version comparison code fails for pytorch 1.10

[matthewfranglen]

A warning is produced when running clip using pytorch version 1.10 or greater.

The version check code performs a comparison using strings. This fails for version 1.10 because string comparison is left to right and 1 is less than 7.

>>> ["1", "10", "0"] < ["1", "7", "1"]
True
>>> ["1", "9", "0"] < ["1", "7", "1"]
False

There is the TorchVersion class that would make this comparison easier to perform however that does not exist in pytorch 1.7. I suggest converting the strings into integers before performing the comparison.

[jongwook]

This was suggested in #160 but using TorchVersion does look cleaner. I'll look into fixing this

[matthewfranglen]

Ah dammit I've just written an identical comparison. Looking at the 1.7 branch of torch I do not see TorchVersion as the torch_version.py file is missing. If you were able to import it to use it then the comparison would pass.

[alex8937]

Got a problem when torch version is 1.9.0a0+2ecb2c7

[vinhkhuc]

Did anyone try packaging.version from setuptools? It seems to work well for the following test cases:

>>> from packaging import version
>>> version.parse("1.5.0") < version.parse("1.7.1")
True
>>> version.parse("1.10.0") < version.parse("1.7.1")
False
>>> version.parse("1.9.0") < version.parse("1.7.1")
False
>>> version.parse("1.9.0a0+2ecb2c7") < version.parse("1.7.1")
False

>>> import torch
>>> type(torch.__version__), torch.__version__
(<class 'torch.torch_version.TorchVersion'>, '1.10.0')
>>> version.parse(torch.__version__) < version.parse("1.7.1")
False

[jiahuei]

This can be closed now since 573315e solves the issue.