Yazeedx0/rtl support #8
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… add pathlib package to uv.lock
- Implemented RTL language detection and text direction functions in `chatkit/i18n.py`. - Added utility functions for handling mixed-direction text and Arabic number formatting. - Created detailed documentation for RTL support in `docs/i18n.md`, including usage examples and best practices. - Developed an example script `examples/rtl_support_example.py` demonstrating various RTL features and widgets. - Added unit tests for RTL functionality in `tests/test_i18n.py`, covering language detection, character detection, and widget support. - Enhanced existing widgets to support RTL text direction and language attributes.
Contributor
|
Hi @Yazeedx0, RTL is on our roadmap, but we need to implement it client side in the ChatKit web component before we do anything else. Ideally, we'll set Regardless, I don't think we want this complexity to live in the server SDK, again you could wrap strings in your own intl layer before passing them to widgets, but even then, it's a stop gap until we can ship proper support for RTL in ChatKit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add comprehensive RTL support and internationalization features
Implemented RTL language detection and text direction functions in chatkit/i18n.py.
Added utility functions for handling mixed-direction text and Arabic number formatting.
Created detailed documentation for RTL support in docs/i18n.md, including usage examples and best practices.
Developed an example script examples/rtl_support_example.py demonstrating various RTL features and widgets.
Added unit tests for RTL functionality in tests/test_i18n.py, covering language detection, character detection, and widget support.
Enhanced existing widgets to support RTL text direction and language attributes.