Skip to content

fix(nix): update flake for newer Rust toolchain requirements#10302

Merged
etraut-openai merged 1 commit intoopenai:mainfrom
douglaz:fix/nix-flake-rust-version
Jan 31, 2026
Merged

fix(nix): update flake for newer Rust toolchain requirements#10302
etraut-openai merged 1 commit intoopenai:mainfrom
douglaz:fix/nix-flake-rust-version

Conversation

@douglaz
Copy link
Contributor

@douglaz douglaz commented Jan 31, 2026

Summary

  • Add rust-overlay input to provide newer Rust versions (rama crates require rustc 1.91.0+)
  • Add devShells output with complete development environment
  • Add missing git dependency hashes to codex-rs/default.nix

Changes

flake.nix:

  • Added rust-overlay input to get newer Rust toolchains
  • Updated packages output to use rust-bin.stable.latest.minimal for builds
  • Added devShells output with:
    • Rust with rust-src and rust-analyzer extensions for IDE support
    • Required build dependencies: pkg-config, openssl, cmake, libclang
    • Environment variables: PKG_CONFIG_PATH, LIBCLANG_PATH

codex-rs/default.nix:

  • Added missing outputHashes for git dependencies:
    • nucleo-0.5.0, nucleo-matcher-0.3.1
    • runfiles-0.1.0
    • tokio-tungstenite-0.28.0, tungstenite-0.28.0

Test Plan

  • nix develop enters shell successfully
  • nix develop -c rustc --version shows 1.93.0
  • nix develop -c cargo build completes successfully

@github-actions
Copy link
Contributor

github-actions bot commented Jan 31, 2026

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@douglaz
Copy link
Contributor Author

douglaz commented Jan 31, 2026

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Jan 31, 2026
@etraut-openai
Copy link
Collaborator

@codex review

@etraut-openai
Copy link
Collaborator

Thanks for the contribution.

We recently updated our contribution guidelines to indicate that we're no longer accepting unsolicited code contributions. All code contributions are by invitation only. To read more about why we've taken this step, please refer to this announcement.

I'm going to exempt this PR from the "by invitation only" guidance because we just recently introduced the change to our guidance plus the contents of the PR are relatively low risk and fast to review. Please follow the new guidance for future PRs.

Does this address all of the problems mentioned in #10044?

@chatgpt-codex-connector
Copy link
Contributor

Codex Review: Didn't find any major issues. 🚀

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

- Add rust-overlay input to provide newer Rust versions
- Update packages output to use rust-bin.stable.latest for builds
- Add devShells output with proper development environment:
  - Rust with rust-src and rust-analyzer extensions
  - Required build deps: pkg-config, openssl, cmake, libclang
  - Environment variables for PKG_CONFIG_PATH and LIBCLANG_PATH
- Add missing git dependency hashes to codex-rs/default.nix:
  - nucleo-0.5.0, nucleo-matcher-0.3.1
  - runfiles-0.1.0
  - tokio-tungstenite-0.28.0, tungstenite-0.28.0

The rama crates now require rustc 1.91.0+, which nixpkgs unstable
doesn't provide. This change uses rust-overlay to get the latest
stable Rust toolchain (1.93.0).
@douglaz douglaz force-pushed the fix/nix-flake-rust-version branch from 0f3d1e3 to a5517f5 Compare January 31, 2026 19:13
@etraut-openai etraut-openai merged commit 9a10121 into openai:main Jan 31, 2026
26 of 32 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2026
@douglaz douglaz deleted the fix/nix-flake-rust-version branch January 31, 2026 21:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants