fix(nix): update flake for newer Rust toolchain requirements#10302
fix(nix): update flake for newer Rust toolchain requirements#10302etraut-openai merged 1 commit intoopenai:mainfrom
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
@codex review |
|
Thanks for the contribution. We recently updated our contribution guidelines to indicate that we're no longer accepting unsolicited code contributions. All code contributions are by invitation only. To read more about why we've taken this step, please refer to this announcement. I'm going to exempt this PR from the "by invitation only" guidance because we just recently introduced the change to our guidance plus the contents of the PR are relatively low risk and fast to review. Please follow the new guidance for future PRs. Does this address all of the problems mentioned in #10044? |
|
Codex Review: Didn't find any major issues. 🚀 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
- Add rust-overlay input to provide newer Rust versions - Update packages output to use rust-bin.stable.latest for builds - Add devShells output with proper development environment: - Rust with rust-src and rust-analyzer extensions - Required build deps: pkg-config, openssl, cmake, libclang - Environment variables for PKG_CONFIG_PATH and LIBCLANG_PATH - Add missing git dependency hashes to codex-rs/default.nix: - nucleo-0.5.0, nucleo-matcher-0.3.1 - runfiles-0.1.0 - tokio-tungstenite-0.28.0, tungstenite-0.28.0 The rama crates now require rustc 1.91.0+, which nixpkgs unstable doesn't provide. This change uses rust-overlay to get the latest stable Rust toolchain (1.93.0).
0f3d1e3 to
a5517f5
Compare
Summary
Changes
flake.nix:
rust-overlayinput to get newer Rust toolchainspackagesoutput to userust-bin.stable.latest.minimalfor buildsdevShellsoutput with:rust-srcandrust-analyzerextensions for IDE supportpkg-config,openssl,cmake,libclangPKG_CONFIG_PATH,LIBCLANG_PATHcodex-rs/default.nix:
outputHashesfor git dependencies:nucleo-0.5.0,nucleo-matcher-0.3.1runfiles-0.1.0tokio-tungstenite-0.28.0,tungstenite-0.28.0Test Plan
nix developenters shell successfullynix develop -c rustc --versionshows 1.93.0nix develop -c cargo buildcompletes successfully