Merged
Conversation
Add rustdoc for ModelClient/ModelClientSession describing ownership, the sticky-routing contract (x-codex-turn-state) and session-scoped WebSocket fallback behavior. Document why x-codex-beta-features is precomputed at session creation and add brief call-site notes about reusing ModelClientSession across retries. No functional changes.
Collaborator
ProblemOpening the Responses WebSocket connection at turn start adds avoidable latency to the first model Mental model
Non-goals
Tradeoffs
Architecture
Observability
Tests
Doc Changes
Risks / Inconsistencies
Tests
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make ModelClient a session-scoped object.
Move state that is session level onto the client, and make state that is per-turn explicit on corresponding methods.
Stop taking a huge Config object, instead only pass in values that are actually needed.