feat: enable premessage-deflate for websockets by apanasenko-oai · Pull Request #10966 · openai/codex

apanasenko-oai · 2026-02-07T03:35:43Z

note:
unfortunately, tokio-tungstenite / tungstenite upgrade triggers some problems with linker of rama-tls-boring with openssl:

error: linking with `/Users/apanasenko/Library/Caches/cargo-zigbuild/0.20.1/zigcc-x86_64-unknown-linux-musl-ff6a.sh` failed: exit status: 1
  |
  = note:  "/Users/apanasenko/Library/Caches/cargo-zigbuild/0.20.1/zigcc-x86_64-unknown-linux-musl-ff6a.sh" "-m64" "<sysroot>/lib/rustlib/x86_64-unknown-linux-musl/lib/self-contained/rcrt1.o" "<sysroot>/lib/rustlib/x86_64-unknown-linux-musl/lib/self-contained/crti.o" "<sysroot>/lib/rustlib/x86_64-unknown-linux-musl/lib/self-contained/crtbeginS.o" "<1 object files omitted>" "-Wl,--as-needed" "-Wl,-Bstatic" "/var/folders/kt/52y_g75x3ng8ktvk3rfwm6400000gp/T/rustcyGQdYm/{liblzma_sys-662a82316f96ec30,libbzip2_sys-bf78a2d58d5cbce6,liblibsqlite3_sys-6c004987fd67a36a,libtree_sitter_bash-220b99a97d331ab7,libtree_sitter-858f0a1dbfea58bd,libzstd_sys-6eb237deec748c5b,libring-2a87376483bf916f,libopenssl_sys-7c189e68b37fe2bb,liblibz_sys-4344eef4345520b1,librama_boring_sys-0414e98115015ee0}.rlib" "-lc++" "-lc++abi" "-lunwind" "-lc" "<sysroot>/lib/rustlib/x86_64-unknown-linux-musl/lib/libcompiler_builtins-*.rlib" "-L" "/var/folders/kt/52y_g75x3ng8ktvk3rfwm6400000gp/T/rustcyGQdYm/raw-dylibs" "-Wl,-Bdynamic" "-Wl,--eh-frame-hdr" "-Wl,-z,noexecstack" "-nostartfiles" "-L" "/Users/apanasenko/code/codex/codex-rs/target/x86_64-unknown-linux-musl/release/build/libz-sys-ff5ea50d88c28ffb/out/lib" "-L" "/Users/apanasenko/code/codex/codex-rs/target/x86_64-unknown-linux-musl/release/build/ring-bdec3dddc19f5a5e/out" "-L" "/Users/apanasenko/code/codex/codex-rs/target/x86_64-unknown-linux-musl/release/build/openssl-sys-96e0870de3ca22bc/out/openssl-build/install/lib" "-L" "/Users/apanasenko/code/codex/codex-rs/target/x86_64-unknown-linux-musl/release/build/zstd-sys-0cc37a5da1481740/out" "-L" "/Users/apanasenko/code/codex/codex-rs/target/x86_64-unknown-linux-musl/release/build/tree-sitter-72d2418073317c0f/out" "-L" "/Users/apanasenko/code/codex/codex-rs/target/x86_64-unknown-linux-musl/release/build/tree-sitter-bash-bfd293a9f333ce6a/out" "-L" "/Users/apanasenko/code/codex/codex-rs/target/x86_64-unknown-linux-musl/release/build/libsqlite3-sys-b78b2cfb81a330fc/out" "-L" "/Users/apanasenko/code/codex/codex-rs/target/x86_64-unknown-linux-musl/release/build/bzip2-sys-69a145cc859ef275/out/lib" "-L" "/Users/apanasenko/code/codex/codex-rs/target/x86_64-unknown-linux-musl/release/build/lzma-sys-07e92d0b6baa6fd4/out" "-L" "/Users/apanasenko/code/codex/codex-rs/target/x86_64-unknown-linux-musl/release/build/rama-boring-sys-0bc2dfbf669addc4/out/build/crypto/" "-L" "/Users/apanasenko/code/codex/codex-rs/target/x86_64-unknown-linux-musl/release/build/rama-boring-sys-0bc2dfbf669addc4/out/build/ssl/" "-L" "/Users/apanasenko/code/codex/codex-rs/target/x86_64-unknown-linux-musl/release/build/rama-boring-sys-0bc2dfbf669addc4/out/build/" "-L" "/Users/apanasenko/code/codex/codex-rs/target/x86_64-unknown-linux-musl/release/build/rama-boring-sys-0bc2dfbf669addc4/out/build" "-L" "<sysroot>/lib/rustlib/x86_64-unknown-linux-musl/lib/self-contained" "-L" "<sysroot>/lib/rustlib/x86_64-unknown-linux-musl/lib" "-o" "/Users/apanasenko/code/codex/codex-rs/target/x86_64-unknown-linux-musl/release/deps/codex_network_proxy-d08268b863517761" "-Wl,--gc-sections" "-static-pie" "-Wl,-z,relro,-z,now" "-Wl,-O1" "-Wl,--strip-all" "-nodefaultlibs" "<sysroot>/lib/rustlib/x86_64-unknown-linux-musl/lib/self-contained/crtendS.o" "<sysroot>/lib/rustlib/x86_64-unknown-linux-musl/lib/self-contained/crtn.o"
  = note: some arguments are omitted. use `--verbose` to show all linker arguments
  = note: warning: ignoring deprecated linker optimization setting '1'
          warning: unable to open library directory '/Users/apanasenko/code/codex/codex-rs/target/x86_64-unknown-linux-musl/release/build/rama-boring-sys-0bc2dfbf669addc4/out/build/crypto/': FileNotFound
          ld.lld: error: duplicate symbol: SSL_export_keying_material
          >>> defined at ssl_lib.c:3816 (ssl/ssl_lib.c:3816)
          >>>            libssl-lib-ssl_lib.o:(SSL_export_keying_material) in archive /var/folders/kt/52y_g75x3ng8ktvk3rfwm6400000gp/T/rustcyGQdYm/libopenssl_sys-7c189e68b37fe2bb.rlib
          >>> defined at t1_enc.cc:205 (/Users/apanasenko/code/codex/codex-rs/target/x86_64-unknown-linux-musl/release/build/rama-boring-sys-0bc2dfbf669addc4/out/boringssl/ssl/t1_enc.cc:205)
          >>>            t1_enc.cc.o:(.text.SSL_export_keying_material+0x0) in archive /var/folders/kt/52y_g75x3ng8ktvk3rfwm6400000gp/T/rustcyGQdYm/librama_boring_sys-0414e98115015ee0.rlib

          ld.lld: error: duplicate symbol: d2i_ASN1_TIME
          >>> defined at a_time.c:27 (crypto/asn1/a_time.c:27)
          >>>            libcrypto-lib-a_time.o:(d2i_ASN1_TIME) in archive /var/folders/kt/52y_g75x3ng8ktvk3rfwm6400000gp/T/rustcyGQdYm/libopenssl_sys-7c189e68b37fe2bb.rlib
          >>> defined at a_time.cc:34 (/Users/apanasenko/code/codex/codex-rs/target/x86_64-unknown-linux-musl/release/build/rama-boring-sys-0bc2dfbf669addc4/out/boringssl/crypto/asn1/a_time.cc:34)
          >>>            a_time.cc.o:(.text.d2i_ASN1_TIME+0x0) in archive /var/folders/kt/52y_g75x3ng8ktvk3rfwm6400000gp/T/rustcyGQdYm/librama_boring_sys-0414e98115015ee0.rlib

that force me to migrate away from rama-tls-boring to rama-tls-rustls and pin ring for rustls.

viyatb-oai

network proxy change is good if the build and tests pass

.github/scripts/install-musl-build-tools.sh

codex-rs/codex-api/src/endpoint/responses_websocket.rs

joshka-oai · 2026-02-07T05:40:22Z

codex-rs/codex-api/src/endpoint/responses_websocket.rs

+fn websocket_config() -> WebSocketConfig {
+    let mut extensions = ExtensionsConfig::default();
+    extensions.permessage_deflate = Some(DeflateConfig::default());
+
+    let mut config = WebSocketConfig::default();
+    config.extensions = extensions;
+    config
+}


nit: Might be useful to capture why we're doing this, what we measured, how we know deflate is right here (if there's any context to add)

cc: @ddr-oai

MODULE.bazel

bolinfest · 2026-02-10T08:37:37Z

Related: #11294

viyatb-oai approved these changes Feb 7, 2026

View reviewed changes

apanasenko-oai force-pushed the anton_panasenko_deflate branch 2 times, most recently from 681bfda to 9507404 Compare February 7, 2026 03:43

feat: deflate messages for websockets

557cfca

apanasenko-oai force-pushed the anton_panasenko_deflate branch 7 times, most recently from c5ce5de to 0d88589 Compare February 7, 2026 05:17

joshka-oai approved these changes Feb 7, 2026

View reviewed changes

apanasenko-oai force-pushed the anton_panasenko_deflate branch 13 times, most recently from d319ddc to 2a82071 Compare February 7, 2026 08:12

chore: migrate rama from rama-tls-boring to rama-tls-rustls

0b5012a

apanasenko-oai force-pushed the anton_panasenko_deflate branch from 2a82071 to 0b5012a Compare February 7, 2026 08:16

apanasenko-oai added 3 commits February 7, 2026 00:20

fix(bazel): repair llvm toolchain patch for resource_dir actions

4497cbc

fix(bazel): provide clang builtin headers with custom resource-dir

11be20b

fix(bazel): expose llvm builtin headers for resource-dir include path

8c56526

apanasenko-oai added 14 commits February 7, 2026 01:23

fix(bazel): provide aws-lc-sys build script runtime inputs

ee005a5

fix(bazel): inject llvm toolchain repo into crate extension

53716b9

fix(bazel): scope aws-lc-sys runtime data by platform

bd18a30

fix(bazel): provide aws-lc-sys runtime artifacts as build script tools

88c3979

fix(bazel): expose runtime tool aliases for aws-lc-sys build scripts

e500be6

fix(bazel): correct llvm patch hunk length for runtimes update

8c843ad

fix(bazel): force aws-lc-sys cmake builder under bzlmod

7f4d3dc

bazel: skip aws-lc-sys memcmp link probe under rules_rs

93ba30b

bazel: keep aws-lc memcmp check by normalizing bazel paths

065ad06

bazel: preserve bazel-out when absolutizing aws-lc probe args

e9ad946

bazel: avoid let-chains in aws-lc build-script patch

9015fb6

bazel: skip aws-lc memcmp probe on apple toolchains

204da6d

bazel: run aws-lc memcmp probe with stripped debug flags

c00badb

fix(bazel): drop unused runtime alias exports from llvm patch

ca02963

bolinfest approved these changes Feb 7, 2026

View reviewed changes

zbarsky-openai reviewed Feb 7, 2026

View reviewed changes

MODULE.bazel Outdated Show resolved Hide resolved

apanasenko-oai force-pushed the anton_panasenko_deflate branch from ff86b9b to ca02963 Compare February 8, 2026 01:35

review feedback

4466cf4

apanasenko-oai merged commit a94505a into main Feb 8, 2026
32 checks passed

apanasenko-oai deleted the anton_panasenko_deflate branch February 8, 2026 01:59

github-actions bot locked and limited conversation to collaborators Feb 8, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: enable premessage-deflate for websockets#10966

feat: enable premessage-deflate for websockets#10966
apanasenko-oai merged 20 commits intomainfrom
anton_panasenko_deflate

apanasenko-oai commented Feb 7, 2026

Uh oh!

viyatb-oai left a comment

Uh oh!

Uh oh!

Uh oh!

joshka-oai Feb 7, 2026

Uh oh!

apanasenko-oai Feb 7, 2026

Uh oh!

Uh oh!

Uh oh!

bolinfest commented Feb 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

apanasenko-oai commented Feb 7, 2026

Uh oh!

viyatb-oai left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

joshka-oai Feb 7, 2026

Choose a reason for hiding this comment

Uh oh!

apanasenko-oai Feb 7, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

bolinfest commented Feb 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants