deflake linux-sandbox NoNewPrivs timeout#11245
Merged
joshka-oai merged 1 commit intomainfrom Feb 10, 2026
Merged
Conversation
bolinfest
approved these changes
Feb 10, 2026
landlock::test_no_new_privs_is_enabled has been timing out in rust-ci (Sandbox(Timeout)) because the 200ms budget for the sandboxed `grep` is occasionally exceeded (observed ~203ms). Use `LONG_TIMEOUT_MS` for this test to make the timeout deterministic and follow the existing timeout policy constants in this file. Refs: - PR run 21836764823 job 63009902779 - main run 21830746538 job 62988079964 - Review feedback on PR #11245 Validation: - Local: cargo test -p codex-linux-sandbox (non-Linux runs 0 tests)
d5dedae to
891084a
Compare
Collaborator
Author
|
Addressed bolinfest suggestion in 891084a: switched test_no_new_privs_is_enabled to LONG_TIMEOUT_MS instead of using an intermediate timeout value. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deflake
codex-linux-sandbox::all suite::landlock::test_no_new_privs_is_enabled.CI has intermittently failed with
Sandbox(Timeout)(exit 124) because the sandboxedgrep '^NoNewPrivs:' /proc/self/statuscan run close to the short timeout budget.This updates only this test to use
LONG_TIMEOUT_MS, which removes the near-threshold timeoutbehavior while keeping the rest of the suite unchanged.
Refs (previous failures):
Validation:
cd codex-rs && cargo test -p codex-linux-sandbox(non-Linux runs 0 tests)