app-server: source /feedback logs from sqlite at trace level

[charley-oai]

Summary

• write app-server SQLite logs at TRACE level when SQLite is enabled
• source app-server /feedback log attachments from SQLite for the requested thread when available
• flush buffered SQLite log writes before /feedback queries them so newly emitted events are not lost behind the async inserter
• include same-process threadless SQLite rows in those /feedback logs so the attachment matches the process-wide feedback buffer more closely
• keep the existing in-memory ring buffer fallback unchanged, including when the SQLite query returns no rows

Details

• add a byte-bounded query_feedback_logs helper in codex-state so /feedback does not fetch all rows before truncating
• scope SQLite feedback logs to the requested thread plus threadless rows from the same process_uuid
• format exported SQLite feedback lines with the log level prefix to better match the in-memory feedback formatter
• add an explicit LogDbLayer::flush() control path and await it in app-server before querying SQLite for feedback logs
• pass optional SQLite log bytes through codex-feedback as the codex-logs.log attachment override
• leave TUI behavior unchanged apart from the updated upload_feedback call signature
• add regression coverage for:
  • newest-within-budget ordering
  • excluding oversized newest rows
  • including same-process threadless rows
  • keeping the newest suffix across mixed thread and threadless rows
  • matching the feedback formatter shape aside from span prefixes
  • falling back to the in-memory snapshot when SQLite returns no logs
  • flushing buffered SQLite rows before querying

Follow-up

• SQLite feedback exports still do not reproduce span prefixes like feedback-thread{thread_id=...}:; there is a TODO(ccunningham) in codex-rs/state/src/log_db.rs for that follow-up.

Testing

• cd codex-rs && cargo test -p codex-state
• cd codex-rs && cargo test -p codex-app-server
• cd codex-rs && just fmt

[charley-oai]

@codex review this

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e760e931d9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[charley-oai]

@codex review this

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7547a70a03

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[charley-oai]

@codex review this

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c7697dac8a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[charley-oai]

@codex review this

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 99acc8e854

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[charley-oai]

@codex review this

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 491bb6d6af

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[charley-oai]

@codex review this

[charley-oai]

@codex I said review this

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. 🚀

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".