fix: accept two macOS automation input shapes for approval payload compatibility#13683
Merged
fix: accept two macOS automation input shapes for approval payload compatibility#13683
Conversation
additionalPermissions.macos.automations to v2 wire shape["..."] and { "bundle_ids": [...] }) for approval payload compatibility
["..."] and { "bundle_ids": [...] }) for approval payload compatibility
leoshimo-oai
approved these changes
Mar 6, 2026
dylan-hurd-oai
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR:
#[serde(default)]toMacOsSeatbeltProfileExtensionsso omitted fields deserialize to secure defaults.Why this change is needed
MacOsAutomationPermissionuses#[serde(try_from = "MacOsAutomationPermissionDe")], so deserialization is controlled byMacOsAutomationPermissionDe. After we aligned v2additionalPermissions.macos.automationsto the core shape, approval payloads started including{ "bundle_ids": [...] }in some paths.MacOsAutomationPermissionDepreviously accepted only"none" | "all"or a plain array, so object-shaped bundle IDs failed withdata did not match any variant of untagged enum MacOsAutomationPermissionDe. This change restores compatibility by accepting both forms while preserving existing normalization behavior (trim values and map empty bundle lists toNone).Validation
saw this error went away when running
: