fix(subagents) share execpolicy by default#13702
Merged
dylan-hurd-oai merged 15 commits intomainfrom Mar 18, 2026
Merged
Conversation
dylan-hurd-oai
force-pushed
the
dh--subagent-exec-policy
branch
from
9c3b7e5 to
a3244e1
Compare
dylan-hurd-oai
force-pushed
the
dh--subagent-exec-policy
branch
3 times, most recently
from
94b86ac to
83f549a
Compare
This was referenced Mar 9, 2026
dylan-hurd-oai
force-pushed
the
dh--subagent-exec-policy
branch
from
83f549a to
ea04315
Compare
dylan-hurd-oai
force-pushed
the
dh--subagent-exec-policy
branch
from
ea04315 to
b360cc1
Compare
jif-oai
approved these changes
Mar 17, 2026
| } | ||
|
|
||
| #[tokio::test(flavor = "multi_thread", worker_threads = 2)] | ||
| async fn spawned_subagent_execpolicy_amendment_propagates_to_parent_session() -> Result<()> { |
Collaborator
There was a problem hiding this comment.
I feel there are a lot of redundant tests in this PR
Collaborator
Author
There was a problem hiding this comment.
Fair point - I'll dedupe before merging
Collaborator
Author
There was a problem hiding this comment.
I think:
- this test in approvals.rs is a bit of a convoluted example but tests the end-to-end flow
- child_uses_parent_exec_policy should be in exec_policy.rs, but should have reasonable test coverage, it's a somewhat brittle piece of logic
- concurrent_execpolicy_amendments_preserve_both_rules is technically different, but overkill / specific. will remove
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
dylan-hurd-oai
force-pushed
the
dh--subagent-exec-policy
branch
from
249b35b to
94d41ea
Compare
dylan-hurd-oai
force-pushed
the
dh--subagent-exec-policy
branch
from
12ef4da to
033ba0a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
If a subagent requests approval, and the user persists that approval to the execpolicy, it should (by default) propagate. We'll need to rethink this a bit in light of coming Permissions changes, though I think this is closer to the end state that we'd want, which is that execpolicy changes to one permissions profile should be synced across threads.
Testing