Clarify js_repl binding reuse guidance#13803
Merged
Conversation
owenlin0
approved these changes
Mar 6, 2026
aaronl-openai
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clarify the
js_replprompt guidance around persistent bindings and redeclaration recovery.This updates the generated
js_replinstructions incore/src/project_doc.rsto prefer this order when a name is already bound:let{ ... }only for short-lived scratch scopeThe prompt now also explicitly warns against wrapping an entire cell in block scope when the goal is to reuse names across later cells.
Why
The previous wording still left too much room for low-value workarounds like whole-cell block wrapping. In downstream browser rollouts, that pattern was adding tokens and preventing useful state reuse across
js_replcells.This change makes the preferred behavior more explicit without changing runtime semantics.
Scope
project_doctests