Serialize shell snapshot stdin test#13878
Merged
aibrahim-oai merged 2 commits intomainfrom Mar 9, 2026
Merged
Conversation
aibrahim-oai
added a commit
that referenced
this pull request
Mar 7, 2026
aibrahim-oai
added a commit
that referenced
this pull request
Mar 7, 2026
aibrahim-oai
added a commit
that referenced
this pull request
Mar 7, 2026
aibrahim-oai
added a commit
that referenced
this pull request
Mar 7, 2026
aibrahim-oai
added a commit
that referenced
this pull request
Mar 7, 2026
aibrahim-oai
added a commit
that referenced
this pull request
Mar 7, 2026
aibrahim-oai
force-pushed
the
dev/flaky-shell-snapshot-stdin-test
branch
from
c9dceb4 to
8b68a19
Compare
aibrahim-oai
added a commit
that referenced
this pull request
Mar 7, 2026
aibrahim-oai
force-pushed
the
dev/flaky-shell-snapshot-stdin-test
branch
from
1f7e05c to
77b0e27
Compare
aibrahim-oai
requested review from
dylan-hurd-oai,
jif-oai and
owenlin0
and removed request for
dylan-hurd-oai and
owenlin0
jif-oai
approved these changes
Mar 9, 2026
| let read_status_path = home.join("stdin-read-status"); | ||
| let read_status_display = read_status_path.display(); | ||
| let bashrc = | ||
| format!("read -t 1 -r ignored\nprintf '%s' \"$?\" > \"{read_status_display}\"\n"); |
Collaborator
There was a problem hiding this comment.
Can you add a comment in the code? I don't understand what the print here is for?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
snapshot_shell_does_not_inherit_stdinnow runs under its own serial key.Why this fixes the flake
Scope