Skip to content

chore: add a separate reject-policy flag for skill approvals#14271

Merged
celia-oai merged 1 commit intomainfrom
dev/cc/new-skill-approval-policy
Mar 10, 2026
Merged

chore: add a separate reject-policy flag for skill approvals#14271
celia-oai merged 1 commit intomainfrom
dev/cc/new-skill-approval-policy

Conversation

@celia-oai
Copy link
Collaborator

@celia-oai celia-oai commented Mar 10, 2026 •
edited
Loading

Summary

  • add skill_approval to RejectConfig and the app-server v2 AskForApproval::Reject payload so skill-script prompts can be configured independently from sandbox and rule-based prompts
  • update Unix shell escalation to reject prompts based on the actual decision source, keeping prefix rules tied to rules, unmatched command fallbacks tied to sandbox_approval, and skill scripts tied to skill_approval
  • regenerate the affected protocol/config schemas and expand unit/integration coverage for the new flag and skill approval behavior

@celia-oai celia-oai force-pushed the dev/cc/new-skill-approval-policy branch 3 times, most recently from 95bac03 to 1cee971 Compare March 10, 2026 23:21
@celia-oai celia-oai force-pushed the dev/cc/new-skill-approval-policy branch from 1cee971 to 5907519 Compare March 10, 2026 23:23
@celia-oai celia-oai changed the title changes chore: add a separate reject-policy flag for skill approvals Mar 10, 2026
@celia-oai celia-oai marked this pull request as ready for review March 10, 2026 23:27
leoshimo-oai
leoshimo-oai approved these changes Mar 10, 2026
View reviewed changes
Copy link
Contributor

@leoshimo-oai leoshimo-oai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - ty!

@celia-oai celia-oai force-pushed the dev/cc/new-skill-approval-policy branch from cf327bb to 5907519 Compare March 10, 2026 23:35
@celia-oai celia-oai enabled auto-merge (squash) March 10, 2026 23:40
@celia-oai celia-oai merged commit 295b56b into main Mar 10, 2026
60 of 62 checks passed
@celia-oai celia-oai deleted the dev/cc/new-skill-approval-policy branch March 10, 2026 23:58
@github-actions github-actions bot locked and limited conversation to collaborators Mar 10, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@leoshimo-oai leoshimo-oai leoshimo-oai approved these changes

@dylan-hurd-oai dylan-hurd-oai Awaiting requested review from dylan-hurd-oai

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@celia-oai @leoshimo-oai