chore(app-server): stop emitting codex/event/ notifications#14392
Merged
chore(app-server): stop emitting codex/event/ notifications#14392
Conversation
owenlin0
requested review from
bolinfest and
celia-oai
and removed request for
bolinfest
owenlin0
force-pushed
the
owen/delete_codex_events_from_app_server2
branch
from
0ca3b8b to
6b1c180
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR stops emitting legacy
codex/event/*notifications from the public app-server transports.It's been a long time coming! app-server was still producing a raw notification stream from core, alongside the typed app-server notifications and server requests, for compatibility reasons. Now, external clients should no longer be depending on those legacy notifications, so this change removes them from the stdio and websocket contract and updates the surrounding docs, examples, and tests to match.
Caveat
I left the "in-process" version of app-server alone for now, since
codex execwas recently based on top of app-server via this in-process form here: #14005Seems like
codex execstill consumes some legacy notifications internally, so this branch only removescodex/event/*from app-server over stdio and websockets.Follow-up
Once
codex execis fully migrated offcodex/event/*notifications, we'll be able to stop emitting them entirely entirely instead of just filtering it at the external transport boundary.