Skip to content

fix: fix symlinked writable roots in sandbox policies#14674

Merged
viyatb-oai merged 10 commits intomainfrom
codex/viyatb/fix-sandbox-root-normalization
Mar 14, 2026
Merged

fix: fix symlinked writable roots in sandbox policies#14674
viyatb-oai merged 10 commits intomainfrom
codex/viyatb/fix-sandbox-root-normalization

Conversation

@viyatb-oai
Copy link
Collaborator

@viyatb-oai viyatb-oai commented Mar 14, 2026

Summary

  • normalize effective readable, writable, and unreadable sandbox roots after resolving special paths so symlinked roots use canonical runtime paths
  • add a protocol regression test for a symlinked writable root with a denied child and update protocol expectations to canonicalized effective paths
  • update macOS seatbelt tests to assert against effective normalized roots produced by the shared policy helpers

Testing

  • just fmt
  • cargo test -p codex-protocol
  • cargo test -p codex-core explicit_unreadable_paths_are_excluded_
  • cargo clippy -p codex-protocol -p codex-core --tests -- -D warnings

Notes

@viyatb-oai viyatb-oai changed the title Fix symlinked writable roots in sandbox policies fix: fix symlinked writable roots in sandbox policies Mar 14, 2026
Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: eebbcbb23a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@etraut-openai
Copy link
Collaborator

@codex review

Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 10d7949f7a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@viyatb-oai viyatb-oai merged commit 9060dc7 into main Mar 14, 2026
32 checks passed
@viyatb-oai viyatb-oai deleted the codex/viyatb/fix-sandbox-root-normalization branch March 14, 2026 20:24
@github-actions github-actions bot locked and limited conversation to collaborators Mar 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bwrap sandbox bind fails with symlinked TMPDIR

2 participants