Skip to content

Add setTimeout support to code mode#16153

Merged
pakrym-oai merged 6 commits intomainfrom
pakrym/add-settimeout-to-codemode
Apr 7, 2026
Merged

Add setTimeout support to code mode#16153
pakrym-oai merged 6 commits intomainfrom
pakrym/add-settimeout-to-codemode

Conversation

@pakrym-oai
Copy link
Copy Markdown
Collaborator

@pakrym-oai pakrym-oai commented Mar 29, 2026

The implementation is less than ideal - it starts a thread per timer. A better approach might be to switch to tokio and use their timer imlementation.

@pakrym-oai
Copy link
Copy Markdown
Collaborator Author

@codex review this

Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 91133138ab

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/code-mode/src/runtime/timers.rs
Comment thread codex-rs/code-mode/src/runtime/timers.rs
@pakrym-oai pakrym-oai enabled auto-merge (squash) April 7, 2026 00:45
@pakrym-oai pakrym-oai merged commit 0de7662 into main Apr 7, 2026
29 of 30 checks passed
@pakrym-oai pakrym-oai deleted the pakrym/add-settimeout-to-codemode branch April 7, 2026 00:46
@github-actions github-actions bot locked and limited conversation to collaborators Apr 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants