Conversation
af3f6cb to
1707cd5
Compare
etraut-openai
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Bazel clippy now catches lints that
cargo clippycan still miss when a crate undercodex-rsforgets to opt into workspace lints. The concrete example here wascodex-rs/app-server/tests/common/Cargo.toml: Bazel flagged a clippy violation inmodels_cache.rs, but Cargo did not because that crate inherited workspace package metadata without declaring[lints] workspace = true.We already mirror the workspace clippy deny list into Bazel after #15955, so we also need a repo-side check that keeps every
codex-rsmanifest opted into the same workspace settings.What changed
.github/scripts/verify_cargo_workspace_manifests.py, which parses everycodex-rs/**/Cargo.tomlwithtomlliband verifies:version.workspace = trueedition.workspace = truelicense.workspace = true[lints] workspace = truecodex-*/codex-utils-*conventions, with explicit exceptions forwindows-sandbox-rsandutils/path-utils.github/workflows/ci.ymlapp-server/tests/common,file-search,feedback,shell-escalation, anddebug-client)Stack created with Sapling. Best reviewed with ReviewStack.