Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
codex-corealready owns too much of the tool stack, andAGENTS.mdexplicitly pushes us to move shared code out ofcodex-coreinstead of letting it keep growing. This PR takes the next incremental step in movingcore/src/toolstowardcodex-rs/toolsby extracting low-coupling tool configuration and image-detail gating logic intocodex-tools.That gives later extraction work a cleaner boundary to build on without trying to move the entire tools subtree in one shot.
What changed
ToolsConfig,ToolsConfigParams, shell backend config, and unified-exec session selection fromcore/src/tools/spec.rsintocodex-toolscodex-toolscodex-coreto consume the newcodex-toolsexports and pass a rendered agent-type description instead of raw role configcodex-rs/tools/src/lib.rsexports-only, with extracted unit tests living in sibling*_tests.rsmodulesTesting
cargo test -p codex-toolscargo test -p codex-core --lib tools::spec::