Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Follow-up to #16379 and #16471.
codex-rs/core/src/tools/spec.rsstill owned the pure discovery-shaping helpers that turn app metadata and discoverable tool metadata into the inputs used bytool_searchandtool_suggest. Those helpers do not needcodex-coreruntime state, so keeping them incodex-corecontinued to blur the crate boundary this migration is trying to tighten.This change keeps pushing spec-only logic behind the
codex-toolsAPI socodex-corecan focus on wiring runtime handlers to the resulting tool definitions.What Changed
collect_tool_search_app_infosandcollect_tool_suggest_entriestocodex-rs/tools/src/tool_discovery.rs.ToolSearchAppSourceadapter type incodex-toolssocodex-corecan pass app metadata into that shared helper logic without exposingToolInfoacross the crate boundary.codex-rs/tools/src/lib.rs, which remains exports-only.codex-rs/core/src/tools/spec.rsto use thosecodex-toolshelpers instead of maintaining localtool_search_app_infosandtool_suggest_entriesfunctions.codex-core.Testing
cargo test -p codex-toolscargo test -p codex-core tools::spec::tests