Conversation
Collaborator
Author
|
@codex review |
Contributor
|
Codex Review: Didn't find any major issues. Keep it up! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Follow-up to #16288: the new dynamic provider auth token flow currently defaults
refresh_interval_msto a non-zero value and rejects0entirely.For command-backed bearer auth,
0should mean "never auto-refresh". That lets callers keep using the cached token until the backend actually returns401 Unauthorized, at which point Codex can rerun the auth command as part of the existing retry path.What changed
ModelProviderAuthInfo.refresh_interval_msto accept0and documented that value as disabling proactive refreshrefresh_interval_ms = 0as an indefinitely reusable cached token, while still rerunning the auth command during unauthorized recoverycore/config.schema.jsonso the schema minimum is0and the new behavior is described in the field docs401recovery behaviorHow tested
cargo test -p codex-protocolcargo test -p codex-logincargo test -p codex-core test_deserialize_provider_auth_config_