Skip to content

core: remove cross-crate re-exports from lib.rs#16512

Merged
bolinfest merged 1 commit intomainfrom
pr16512
Apr 2, 2026
Merged

core: remove cross-crate re-exports from lib.rs#16512
bolinfest merged 1 commit intomainfrom
pr16512

Conversation

@bolinfest
Copy link
Copy Markdown
Collaborator

@bolinfest bolinfest commented Apr 2, 2026

Why

codex-core was re-exporting APIs owned by sibling codex-* crates, which made downstream crates depend on codex-core as a proxy module instead of the actual owner crate.

Removing those forwards makes crate boundaries explicit and lets leaf crates drop unnecessary codex-core dependencies. In this PR, this reduces the dependency on codex-core to codex-login in the following files:

codex-rs/backend-client/Cargo.toml
codex-rs/mcp-server/tests/common/Cargo.toml

What

  • Remove codex-rs/core/src/lib.rs re-exports for symbols owned by codex-login, codex-mcp, codex-rollout, codex-analytics, codex-protocol, codex-shell-command, codex-sandboxing, codex-tools, and codex-utils-path.
  • Delete the default_client forwarding shim in codex-rs/core.
  • Update in-crate and downstream callsites to import directly from the owning codex-* crate.
  • Add direct Cargo dependencies where callsites now target the owner crate, and remove codex-core from codex-rs/backend-client.

@bolinfest bolinfest requested a review from aibrahim-oai April 2, 2026 05:41
@bolinfest bolinfest changed the title fix: eliminate re-exports in codex-rs/core/lib.rs core: remove cross-crate re-exports from lib.rs Apr 2, 2026
@bolinfest bolinfest merged commit aa2403e into main Apr 2, 2026
47 of 52 checks passed
@bolinfest bolinfest deleted the pr16512 branch April 2, 2026 06:06
@github-actions github-actions bot locked and limited conversation to collaborators Apr 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant