Conversation
bolinfest
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The main Bazel CI lanes need compact execution logs to investigate cache misses and unexpected rebuilds, but local users of the shared wrapper should not pay that log-generation cost by default.
What Changed
.github/scripts/run-bazel-ci.shnow appends--execution_log_compact_file=...only whenCODEX_BAZEL_EXECUTION_LOG_COMPACT_DIRis set; the caller owns creating that directory..github/workflows/bazel.ymlenables that env var only for the maintestandclippyjobs, creates the temp log directory in each job, and uploads the resulting*.zstfiles fromrunner.temp.Verification
bash -n .github/scripts/run-bazel-ci.sh.github/workflows/bazel.ymlas YAML.execution-log-cquery-local-*.zstwhen the caller pre-createsCODEX_BAZEL_EXECUTION_LOG_COMPACT_DIR.