Fix non-determinism in rules_rs/crate_git_repository.bzl#16590
Merged
bolinfest merged 1 commit intoopenai:mainfrom Apr 2, 2026
Merged
Fix non-determinism in rules_rs/crate_git_repository.bzl#16590bolinfest merged 1 commit intoopenai:mainfrom
bolinfest merged 1 commit intoopenai:mainfrom
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
bolinfest
changed the title
bolinfest
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running multiple builds with no changes causes some differences, we see that https://app.buildbuddy.io/compare/a9719629-1660-4735-a477-d66357f234fb...df85310b-eb5c-4c10-8b79-4d0449ba6cdd#file shows the file-differences between two Bazel builds.
These differences are caused by a non-deterministic
.gitentry in the rules_rs crates that are created withcrate_git_repository.As a way to make these deterministic, we can remove this entry after we download the git source, so that the input to the compile action is deterministic.
CLA
I have read the CLA Document and I hereby sign the CLA