fix: add shell fallback paths for pwsh/powershell that work on GitHub Actions Windows runners#16617
Conversation
… Actions Windows runners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently, I merged a number of PRs to increase startup timeouts for scripts that ran under PowerShell, but in the failure for
suite::codex_tool::test_shell_command_approval_triggers_elicitation, I found this in the error logs when running on Bazel with BuildBuddy:This error implies that the command was run under
cmd.exeinstead ofpwsh.exe. Under GitHub Actions, I suspect that the%PATH%that is passed to our Bazel builder is scrubbed such that our tests cannot find PowerShell where GitHub installs it. Having these explicit fallback paths should help.While we could enable these only for tests, I don't see any harm in keeping them in production, as well.