Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
thread/shellCommandexecutes the raw command string through the current user shell, which is PowerShell on Windows. The two v2 app-server tests inapp-server/tests/suite/v2/thread_shell_command.rsused POSIXprintf, so Bazel CI on Windows failed withprintfnot being recognized as a PowerShell command.For reference, the user-shell task wraps commands with the active shell before execution:
core/src/tasks/user_shell.rs.What Changed
Added a test-local helper that builds a shell-appropriate output command and expected newline sequence from
default_user_shell():Write-Output '...'with\r\necho ...with\r\nprintf '%s\n' ...with\nBoth
thread_shell_command_runs_as_standalone_turn_and_persists_historyandthread_shell_command_uses_existing_active_turnnow use that helper.Verification
cargo test -p codex-app-server thread_shell_command