Skip to content

fix: use COMSPEC in Windows unicode shell test#16665

Merged
bolinfest merged 1 commit intomainfrom
pr16665
Apr 3, 2026
Merged

fix: use COMSPEC in Windows unicode shell test#16665
bolinfest merged 1 commit intomainfrom
pr16665

Conversation

@bolinfest
Copy link
Copy Markdown
Collaborator

@bolinfest bolinfest commented Apr 3, 2026

Why

Windows Bazel shell tests launch PowerShell with a curated environment, so PATHEXT may be absent. The existing unicode_output test invokes bare cmd, which can fail before the test exercises UTF-8 child-process output.

What

  • Use $env:COMSPEC /c echo naïve_café in the Windows branch of unicode_output.
  • Preserve the external child-process path instead of switching the test to a PowerShell builtin.

Verification

  • cargo test -p codex-core unicode_output

@bolinfest bolinfest merged commit 14f95db into main Apr 3, 2026
20 of 21 checks passed
@bolinfest bolinfest deleted the pr16665 branch April 3, 2026 06:54
@github-actions github-actions bot locked and limited conversation to collaborators Apr 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant