Wire realtime WebRTC native media into Bazel#17145
Conversation
aibrahim-oai
commented
Apr 8, 2026
aibrahim-oai
commented
- Builds codex-realtime-webrtc through the normal Bazel Rust macro so native macOS WebRTC sources are included.\n- Shares the macOS -ObjC link flag with Bazel targets that can link libwebrtc.
aibrahim-oai
force-pushed
the
realtime-webrtc-bazel-native
branch
from
a3bd44d to
4fdcf57
Compare
aibrahim-oai
force-pushed
the
realtime-webrtc-bazel-native
branch
from
4fdcf57 to
571829e
Compare
Remove the codex_bazel native stub and build the realtime WebRTC crate through the normal Bazel crate macro. Share the macOS -ObjC link flag with the Bazel binaries/tests that can pull libwebrtc in. Co-authored-by: Codex <noreply@openai.com>
aibrahim-oai
force-pushed
the
realtime-webrtc-bazel-native
branch
from
571829e to
c0c3e58
Compare
|
@codex review this |
Add the missing image-generation auth flag in the remaining ToolsConfigParams test helpers, and correct the webrtc-sys patch hunk size so Bazel can apply it.\n\nCo-authored-by: Codex <noreply@openai.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ecf380b2f5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Expose the hermetic sysroot patch from the patches package so MODULE.bazel can reference it by label.\n\nCo-authored-by: Codex <noreply@openai.com>
Correct the old-side hunk length; the patch removes a blank line as part of replacing the xcrun-based sysroot lookup.\n\nCo-authored-by: Codex <noreply@openai.com>
Keep patch_args at -p1 and use a/build.rs so Bazel can find the webrtc-sys build script.\n\nCo-authored-by: Codex <noreply@openai.com>
Extend the webrtc-sys build-script patch to use Bazel's CC when querying linker search directories.\n\nCo-authored-by: Codex <noreply@openai.com>
Reduce the webrtc-sys patch to the two tool lookup replacements so it applies cleanly to the Bazel-resolved crate version.\n\nCo-authored-by: Codex <noreply@openai.com>
Teach the patched webrtc-sys build script to pass the hermetic SDK's framework directory to cc-rs when cross-compiling for macOS.\n\nCo-authored-by: Codex <noreply@openai.com>
|
@codex review this |
There was a problem hiding this comment.
💡 Codex Review
codex/codex-rs/cloud-tasks/BUILD.bazel
Lines 3 to 5 in 1fc3029
Add macOS WebRTC link flags to cloud-tasks Bazel target
This change enables native codex-realtime-webrtc for Bazel, and the new flag comment states any macOS binary/test that can pull libwebrtc must link with -ObjC. codex-cloud-tasks depends on codex-tui, so its Bazel test binaries can transitively link libwebrtc, but this target still omits MACOS_WEBRTC_RUSTC_LINK_FLAGS. That can drop ObjC category symbols and cause runtime WebRTC initialization failures on macOS.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
aibrahim-oai
force-pushed
the
realtime-webrtc-bazel-native
branch
6 times, most recently
from
620826a to
822c066
Compare
Co-authored-by: Codex <noreply@openai.com>
aibrahim-oai
force-pushed
the
realtime-webrtc-bazel-native
branch
from
822c066 to
a4df77a
Compare
|
@codex review this |
|
Codex Review: Didn't find any major issues. What shall we delve into next? ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
2 participants
