Skip to content

Always enable original image detail on supported models#17665

Merged
fjord-oai merged 1 commit intomainfrom
fjord/image_detail_cleanup
Apr 14, 2026
Merged

Always enable original image detail on supported models#17665
fjord-oai merged 1 commit intomainfrom
fjord/image_detail_cleanup

Conversation

@fjord-oai
Copy link
Copy Markdown
Contributor

Summary

This PR removes image_detail_original as a runtime experiment and makes original image detail available whenever the selected model supports it.

Concretely, this change:

  • drops the image_detail_original feature flag from the feature registry and generated config schema
  • makes tool-emitted image detail depend only on ModelInfo.supports_image_detail_original
  • updates view_image and code_mode/js_repl image emission to use that capability check directly
  • removes now-redundant experiment-specific tests and instruction coverage
  • keeps backward compatibility for existing configs by silently ignoring a stale features.image_detail_original entry

The net effect is that detail: "original" is always available on supported models, without requiring an experiment toggle.

@fjord-oai
Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown
Contributor

Codex Review: Didn't find any major issues. Nice work!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@fjord-oai fjord-oai force-pushed the fjord/image_detail_cleanup branch from 4bd701b to c8473fc Compare April 13, 2026 18:20
@fjord-oai fjord-oai merged commit f030ab6 into main Apr 14, 2026
26 of 30 checks passed
@fjord-oai fjord-oai deleted the fjord/image_detail_cleanup branch April 14, 2026 15:15
@github-actions github-actions bot locked and limited conversation to collaborators Apr 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants