Add server-level approval defaults for custom MCP servers#17843
Merged
mzeng-openai merged 4 commits intomainfrom Apr 16, 2026
Merged
Add server-level approval defaults for custom MCP servers#17843mzeng-openai merged 4 commits intomainfrom
mzeng-openai merged 4 commits intomainfrom
Conversation
shijie-oai
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
default_tools_approval_modesupport for custom MCP server configs, matching the existingcodex_appsbehaviorautoTesting
cargo check -p codex-configcargo check -p codex-corejust write-config-schemajust fmtcargo test -p codex-configcodex-coretests for config parsing, config writes, and MCP approval precedencejust fix -p codex-config -p codex-core