Wire the PatchUpdated events through app_server by akshaynathan · Pull Request #18289 · openai/codex

akshaynathan · 2026-04-17T05:30:29Z

Wires patch_updated events through app_server. These events are parsed and streamed while apply_patch is being written by the model. The eventual goal is to use this to display better progress indicators in the codex app.

…onses api. This is to enable clients to show progress during file writes. This does not work with apply_patch in function call mode, since that required adding streaming json parsing.

…s-apply-patch-events

…pply-patch-streaming-app-server

…s-apply-patch-events

…pply-patch-streaming-app-server

…s-apply-patch-events

…pply-patch-streaming-app-server

…onses api. This is to enable clients to show progress during file writes. This does not work with apply_patch in function call mode, since that required adding streaming json parsing.

…pply-patch-streaming-app-server # Conflicts: # codex-rs/apply-patch/src/parser.rs # codex-rs/core/src/codex.rs # codex-rs/core/tests/suite/apply_patch_cli.rs

chatgpt-codex-connector · 2026-04-17T05:41:04Z

💡 Codex Review

codex/codex-rs/core/src/tools/handlers/apply_patch.rs

Line 93 in 65663cf

let path = hunk_source_path(hunk).to_path_buf();

Resolve streamed patch paths against cwd

PatchApplyUpdated currently keys changes by the raw hunk path (hunk_source_path), so relative patch inputs emit relative paths in progress events. The begin/end file-change items for the same call are built from verified ApplyPatchAction paths (resolved against cwd), so clients can see the same file switch from relative to absolute path mid-lifecycle and treat it as a different entry. Normalize streamed paths the same way as begin/end to keep item updates stable.

codex/codex-rs/core/src/codex/turn.rs

Lines 1964 to 1968 in 65663cf

    
           if let ResponseItem::CustomToolCall { call_id, name, .. } = &item { 
        
               let tool_name = ToolName::plain(name.as_str()); 
        
               active_tool_argument_diff_consumer = tool_runtime 
        
                   .create_diff_consumer(&tool_name) 
        
                   .map(|consumer| (call_id.clone(), consumer));

Support function-call apply_patch when streaming is enabled

The diff consumer is only created for CustomToolCall items; FunctionCall items clear the active consumer. As a result, apply_patch_streaming_events produces no PatchApplyUpdated events when apply_patch is invoked through the JSON/function-call path (which remains possible unless freeform is also enabled), making the feature flag a no-op in that configuration.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

…eaming-app-server # Conflicts: # codex-rs/app-server-protocol/schema/typescript/ServerNotification.ts

…eaming-app-server

pakrym-oai · 2026-04-18T00:15:27Z

    /// Emitted when an item is updated.
    #[serde(rename = "item.updated")]
    ItemUpdated(ItemUpdatedEvent),
+    /// Emitted when the model starts streaming input for an item.


I would revert all exec changes. We don't actively add APIs to it.

pakrym-oai

Let's not touch exec

…eaming-app-server # Conflicts: # codex-rs/app-server-protocol/schema/typescript/ServerNotification.ts

…eaming-app-server

akshaynathan · 2026-04-20T16:40:15Z

Removed exec changes and added 500ms buffering of events.

akshaynathan added 30 commits April 14, 2026 17:46

Adds a new event for streaming apply_patch changes directly from resp…

c818db0

…onses api. This is to enable clients to show progress during file writes. This does not work with apply_patch in function call mode, since that required adding streaming json parsing.

Expose streaming apply_patch patch deltas over app-server and exec

ab5c5ac

Merge remote-tracking branch 'origin/main' into draft-stream-response…

aa91fe9

…s-apply-patch-events

Merge branch 'draft-stream-responses-apply-patch-events' into draft-a…

5502637

…pply-patch-streaming-app-server

Merge remote-tracking branch 'origin/main' into draft-stream-response…

3e9b6e0

…s-apply-patch-events

Move apply_patch streaming into tool handler

21aa353

Merge branch 'draft-stream-responses-apply-patch-events' into draft-a…

cac6751

…pply-patch-streaming-app-server

Check apply_patch streaming flag while consuming deltas

da1b53f

Merge branch 'draft-stream-responses-apply-patch-events' into draft-a…

6a24ba5

…pply-patch-streaming-app-server

Use direct box for diff consumer trait object

28a36a2

Merge branch 'draft-stream-responses-apply-patch-events' into draft-a…

2295785

…pply-patch-streaming-app-server

Keep apply_patch diff state in consumer

945bb2d

Merge branch 'draft-stream-responses-apply-patch-events' into draft-a…

8f6ce5f

…pply-patch-streaming-app-server

Merge remote-tracking branch 'origin/main' into draft-stream-response…

c7edd7e

…s-apply-patch-events

Stabilize file watcher throttle test

9dc532e

Merge remote-tracking branch 'origin/main' into draft-stream-response…

562aa38

…s-apply-patch-events

Address apply_patch streaming review comments

2d9f8bf

Merge branch 'draft-stream-responses-apply-patch-events' into draft-a…

e8b6344

…pply-patch-streaming-app-server

Simplify streaming patch boundary parsing

20aa0c5

Merge branch 'draft-stream-responses-apply-patch-events' into draft-a…

9566b28

…pply-patch-streaming-app-server

Simplify streaming patch boundary parsing

ee0456a

Update app-server apply_patch streaming event

029bf4d

Adds a new event for streaming apply_patch changes directly from resp…

2e346e8

…onses api. This is to enable clients to show progress during file writes. This does not work with apply_patch in function call mode, since that required adding streaming json parsing.

Move apply_patch streaming into tool handler

423ea87

Check apply_patch streaming flag while consuming deltas

6cf4842

Use direct box for diff consumer trait object

d0a2659

Keep apply_patch diff state in consumer

1d7fde3

Stabilize file watcher throttle test

02bee34

Address apply_patch streaming review comments

2e8c43b

Simplify streaming patch boundary parsing

0e0fb63

akshaynathan and others added 6 commits April 16, 2026 16:05

Trigger CI rerun

4de8d61

Address streaming parser review feedback

8fbb1c1

Simplify streaming hunk error handling

721a27c

Merge branch 'draft-stream-responses-apply-patch-events' into draft-a…

65663cf

…pply-patch-streaming-app-server # Conflicts: # codex-rs/apply-patch/src/parser.rs # codex-rs/core/src/codex.rs # codex-rs/core/tests/suite/apply_patch_cli.rs

Merge branch 'main' into draft-apply-patch-streaming-app-server

fc35c7e

Update README.md

6655351

akshaynathan changed the title ~~[DRAFT] Wire PatchUpdated events through app-server~~ Wire the PatchUpdated events through app_server Apr 17, 2026

akshaynathan requested a review from pakrym-oai April 17, 2026 05:34

akshaynathan added 3 commits April 17, 2026 08:45

Merge remote-tracking branch 'origin/main' into draft-apply-patch-str…

d3789dc

…eaming-app-server # Conflicts: # codex-rs/app-server-protocol/schema/typescript/ServerNotification.ts

Merge remote-tracking branch 'origin/main' into draft-apply-patch-str…

d931f46

…eaming-app-server

Merge remote-tracking branch 'origin/main' into draft-apply-patch-str…

b34428b

…eaming-app-server

pakrym-oai reviewed Apr 18, 2026

View reviewed changes

pakrym-oai approved these changes Apr 18, 2026

View reviewed changes

Buffer apply_patch streaming updates in diff consumer

1452501

github-actions Bot mentioned this pull request Apr 20, 2026

📊 AI CLI 工具社区动态日报 2026-04-20 gsscsd/big_model_radar#214

Open

akshaynathan added 4 commits April 20, 2026 08:49

Remove exec streaming patch events

6891289

Merge remote-tracking branch 'origin/main' into draft-apply-patch-str…

28fd83a

…eaming-app-server # Conflicts: # codex-rs/app-server-protocol/schema/typescript/ServerNotification.ts

Rename diff consumer completion flush hook

e72ae8f

Fix agent identity auth test fixture

2dd2fb9

akshaynathan requested a review from a team as a code owner April 20, 2026 16:35

Merge remote-tracking branch 'origin/main' into draft-apply-patch-str…

e7ee0da

…eaming-app-server

akshaynathan merged commit 34a3e85 into main Apr 20, 2026
25 checks passed

akshaynathan deleted the draft-apply-patch-streaming-app-server branch April 20, 2026 17:44

github-actions Bot locked and limited conversation to collaborators Apr 20, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Wire the PatchUpdated events through app_server#18289

Wire the PatchUpdated events through app_server#18289
akshaynathan merged 45 commits intomainfrom
draft-apply-patch-streaming-app-server

akshaynathan commented Apr 17, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot commented Apr 17, 2026

Uh oh!

pakrym-oai Apr 18, 2026

Uh oh!

akshaynathan Apr 20, 2026

Uh oh!

pakrym-oai left a comment

Uh oh!

akshaynathan commented Apr 20, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

akshaynathan commented Apr 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector Bot commented Apr 17, 2026

💡 Codex Review

Uh oh!

pakrym-oai Apr 18, 2026

Choose a reason for hiding this comment

Uh oh!

akshaynathan Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

pakrym-oai left a comment

Choose a reason for hiding this comment

Uh oh!

akshaynathan commented Apr 20, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

akshaynathan commented Apr 17, 2026 •

edited

Loading