feat(auto-review) Handle request_permissions calls#18393
Merged
dylan-hurd-oai merged 5 commits intomainfrom Apr 21, 2026
Merged
feat(auto-review) Handle request_permissions calls#18393dylan-hurd-oai merged 5 commits intomainfrom
dylan-hurd-oai merged 5 commits intomainfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dcca7d30e2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
dylan-hurd-oai
force-pushed
the
dh--guardian--request-perm
branch
from
dcca7d3 to
840e9d9
Compare
dylan-hurd-oai
force-pushed
the
dh--guardian--request-perm
branch
3 times, most recently
from
5f4a4a8 to
c39399f
Compare
dylan-hurd-oai
changed the title
dylan-hurd-oai
force-pushed
the
dh--guardian--request-perm
branch
2 times, most recently
from
bbb2990 to
a5f62c1
Compare
won-openai
approved these changes
Apr 20, 2026
jif-oai
approved these changes
Apr 20, 2026
Collaborator
jif-oai
left a comment
jif-oai
left a comment
There was a problem hiding this comment.
After those 2 comments, lgtm
| _ = cancellation_token.cancelled() => return None, | ||
| decision = review_rx => decision.unwrap_or(ReviewDecision::Denied), | ||
| }; | ||
| let response = match decision { |
Collaborator
There was a problem hiding this comment.
If I read this correctly, approved for session won't work anymore right? Is this expected?
Collaborator
Author
There was a problem hiding this comment.
I think it's just that Guardian doesn't approve for session, which is fine?
Co-authored-by: Codex <noreply@openai.com>
Route request_permissions approvals through guardian review when configured, while keeping the permission grant recorded against the originating turn. Keep the request_permissions path simple by avoiding extra cancellation-token plumbing. Co-authored-by: Codex <noreply@openai.com>
dylan-hurd-oai
force-pushed
the
dh--guardian--request-perm
branch
from
8f705ff to
a9498a4
Compare
Use the canonical FileSystemPermissions helper in the guardian request_permissions snapshot test so Bazel compiles against the current protocol shape. Refresh the snapshot footer for the rebased default model. Co-authored-by: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When auto-review is enabled, it should handle request_permissions tool. We'll need to clean up the UX but I'm planning to do that in a separate pass
Testing