Conversation
This was referenced Apr 17, 2026
pakrym-oai
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the second cleanup in the await-holding lint stack. The higher-level goal, following #18178 and #18398, is to enable Clippy coverage for guards held across
.awaitpoints without carrying broad suppressions.The stack is working toward enabling Clippy's
await_holding_locklint and the configurableawait_holding_invalid_typelint for Tokio guard types.Several existing fields used
tokio::sync::Mutex<()>only as one-at-a-time async gates. Those guards intentionally lived across.awaitwhile an operation was serialized. A mutex over()suggests protected data and trips the await-holding lint shape; a single-permittokio::sync::Semaphoreexpresses the intended serialization directly.What changed
Mutex<()>serialization gates withSemaphore::new(1)for agent identity ensure, exec policy updates, guardian review session reuse, plugin remote sync, managed network proxy refresh, auth token refresh, and RMCP session recovery.lock().await/try_lock()toacquire().await/try_acquire().managed_network_proxy_refresh_locktype.Verification
just clippy.Stack created with Sapling. Best reviewed with ReviewStack.