Skip to content

/statusline & /title - Shared preview values#18435

Merged
canvrno-oai merged 13 commits intomainfrom
canvrno/18162-shared-preview-values
Apr 21, 2026
Merged

/statusline & /title - Shared preview values#18435
canvrno-oai merged 13 commits intomainfrom
canvrno/18162-shared-preview-values

Conversation

@canvrno-oai
Copy link
Copy Markdown
Contributor

@canvrno-oai canvrno-oai commented Apr 18, 2026

This PR makes the /statusline and /title setup UIs share one preview-value source instead of each surface using its own examples. Both pickers now render consistent live values when available, and stable placeholders when they are not. It also resolves live preview values at the shared preview-item layer, so /title preview can use real runtime values for title-specific cases like status text, task progress, and project-name fallback behavior.

  • Adds a shared preview data model for status surfaces
  • Maps status-line items and terminal-title items onto that shared preview list
  • Feeds both setup views from the same chatwidget-derived preview data, with terminal-title-specific formatting applied before /title preview renders
  • Keeps project-root preview aligned with status-line behavior while project in /title keeps its title fallback/truncation behavior
  • Adds snapshot coverage for live-only, hardcoded-only, and mixed cases

Test Steps

  • Open Codex TUI and launch /statusline.
  • Toggle and reorder items, then verify the preview uses current session values when possible, and placeholder values for missing values (ex: no thread ID).
  • Open /title and verify it shows the same normalized values, including live status/task-progress values when available.

@canvrno-oai
Copy link
Copy Markdown
Contributor Author

@codex review

Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: be8531d182

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/tui/src/chatwidget.rs Outdated
@canvrno-oai
Copy link
Copy Markdown
Contributor Author

@codex review

Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2cdb632207

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/tui/src/chatwidget/status_surfaces.rs
@canvrno-oai canvrno-oai force-pushed the canvrno/18162-shared-preview-values branch from 3e92967 to 8181de3 Compare April 20, 2026 18:12
@canvrno-oai
Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown
Contributor

Codex Review: Didn't find any major issues. Keep it up!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@canvrno-oai canvrno-oai marked this pull request as ready for review April 20, 2026 23:39
Copy link
Copy Markdown
Collaborator

@etraut-openai etraut-openai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.

I also built locally and gave it a try and didn't see any visible or behavioral regressions.

@canvrno-oai canvrno-oai merged commit 9a2b342 into main Apr 21, 2026
25 checks passed
@canvrno-oai canvrno-oai deleted the canvrno/18162-shared-preview-values branch April 21, 2026 00:46
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 21, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants