Fix exec inheritance of root shared flags#18630
Merged
etraut-openai merged 1 commit intomainfrom Apr 20, 2026
Merged
Conversation
fcoury-oai
reviewed
Apr 20, 2026
Contributor
fcoury-oai
left a comment
fcoury-oai
left a comment
There was a problem hiding this comment.
The first issue about replicating the shared options for Review is not a blocked and can be either addressed as a follow-up PR or in this one if you prefer.
I think we should fix the other issue of conflicting permissions.
There are also some merge conflicts now on this PR. Once you take another pass and decide how to address those issues, I can do a final pass.
etraut-openai
force-pushed
the
etraut/fix-exec-root-shared-flags
branch
from
6527339 to
e378372
Compare
fcoury-oai
approved these changes
Apr 20, 2026
Contributor
fcoury-oai
left a comment
fcoury-oai
left a comment
There was a problem hiding this comment.
Only did a sanity check locally with exec and the good looks good. Approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #18113
Problem: Shared flags provided before the exec subcommand were parsed by the root CLI but not inherited by the exec CLI, so exec sessions could run with stale or default sandbox and model configuration.
Solution: Move shared TUI and exec flags into a common option block and merge root selections into exec before dispatch, while preserving exec's global subcommand flag behavior.