Stabilize debug clear memories integration test#18858
Merged
Conversation
sayan-oai
approved these changes
Apr 21, 2026
jif-oai
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
debug_clear_memories_resets_state_and_removes_memory_dircan be flaky because the test drops itssqlx::SqlitePoolimmediately before invokingcodex debug clear-memories. Dropping the pool does not wait for all SQLite connections to close, so the CLI can race with still-open test connections.What changed
pool.close()before spawningcodex debug clear-memories.CODEX_HOMEis torn down.Verification
cargo test -p codex-cli --test debug_clear_memories debug_clear_memories_resets_state_and_removes_memory_dir