Lift app-server JSON-RPC error handling to request boundary#19484
Merged
pakrym-oai merged 2 commits intomainfrom Apr 26, 2026
Merged
Lift app-server JSON-RPC error handling to request boundary#19484pakrym-oai merged 2 commits intomainfrom
pakrym-oai merged 2 commits intomainfrom
Conversation
aibrahim-oai
approved these changes
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
App-server request handling had a lot of repeated JSON-RPC error construction and one-off
send_error/returnbranches. This made small handlers noisy and pushed error response details into leaf code that otherwise only needed to validate input or call the underlying API.What Changed
codex-rs/app-server/src/error_code.rs.codex-rs/app-server/src/message_processor.rsso response/error dispatch happens at the request boundary.Verification
cargo test -p codex-app-server --lib command_exec::testscargo test -p codex-app-server --lib outgoing_message::testscargo test -p codex-app-server --lib in_process::testscargo test -p codex-app-server --test all v2::fscargo test -p codex-app-server --test all v2::config_rpccargo test -p codex-app-server --test all v2::external_agent_configcargo test -p codex-app-server --test all v2::initializejust fix -p codex-app-servergit diff --checkNote: full
cargo test -p codex-app-serverwas attempted and stopped inmessage_processor::tracing_tests::turn_start_jsonrpc_span_parents_core_turn_spanswith a stack overflow after unrelated tests had already passed.