Split MCP connection modules#19725
Merged
aibrahim-oai merged 6 commits intomainfrom Apr 26, 2026
Merged
Conversation
Split the former MCP connection manager module into focused modules for manager orchestration, RMCP client startup, elicitation handling, Codex Apps support, tool helpers, and runtime support. Preserve latest main's PermissionProfile-based MCP elicitation approval behavior while applying the module split. Co-authored-by: Codex <noreply@openai.com>
This was referenced Apr 26, 2026
Rename the split codex-mcp modules so filenames include the MCP responsibility they own, such as mcp_connection_manager.rs, rmcp_client.rs, mcp_elicitation.rs, codex_apps.rs, mcp_tools.rs, and mcp_runtime.rs. Co-authored-by: Codex <noreply@openai.com>
Add module-level docs explaining the ownership boundary of each split codex-mcp module. Co-authored-by: Codex <noreply@openai.com>
Collaborator
Author
|
@codex review this |
Rename split codex-mcp modules to drop redundant mcp_ prefixes while keeping rmcp_client.rs specific to the RMCP client layer. Co-authored-by: Codex <noreply@openai.com>
pakrym-oai
approved these changes
Apr 26, 2026
Order moved module items by visibility and primary entry points so public APIs come before supporting helpers. Co-authored-by: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The MCP connection manager module had grown to mix orchestration, RMCP client startup, elicitation handling, Codex Apps cache and naming behavior, tool qualification and filtering, and runtime data. The previous stacked PRs split these responsibilities incrementally; this PR collapses that work into one self-contained refactor on latest main.
What changed
Verification