Conversation
pakrym-oai
approved these changes
Apr 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Increase
core-all-test's Bazel shard count from8to16.Why
#19609 restored
bazel.ymlto a 30-minute timeout and increasedapp-server-all-test's shard count because the bigger timeout risk was not just a cold Windows build. The more common problem was a longrust_test()shard failing and getting retried multiple times.Recent
mainruns show that//codex-rs/core:core-all-teststill has the same shape of problem on Windows://codex-rs/core:core-all-testas flaky after first-attempt failures in shard5/8and shard8/8.suite::cli_stream::responses_mode_stream_cli_supports_openai_base_url_config_overrideandsuite::pending_input::steered_user_input_waits_when_tool_output_triggers_compact_before_next_request.272.61sand259.27sbefore retrying, which is exactly the sort of wall-clock cost that burns through the 30-minute budget.//codex-rs/tui:tui-unit-testsafterapp::tests::update_memory_settings_updates_current_thread_memory_modefailed once on Windows.bazel test //...step can already consume24m11son its own, leaving very little headroom for flaky retries.Increasing
core-all-testto16shards does not fix the flaky tests, but it does reduce the wall-clock cost when a single shard has to be retried. That matches the mitigation we already applied toapp-server-all-testin#19609.What Changed
codex-rs/core/BUILD.bazelsocore-all-testuses16shards instead of8.core-unit-testsunchanged.Follow-up Work
This change is meant to buy back CI headroom while we fix the flaky tests themselves in subsequent commits. The recent Windows retries that look worth addressing directly include:
suite::cli_stream::responses_mode_stream_cli_supports_openai_base_url_config_overridesuite::pending_input::steered_user_input_waits_when_tool_output_triggers_compact_before_next_requestapp::tests::update_memory_settings_updates_current_thread_memory_modeVerification
core-all-test's current sharding against theapp-server-all-testprecedent in #19609.mainBazel workflow logs and the linked BuildBuddy invocation to confirm that Windows retries on long shards are still consuming a meaningful fraction of the 30-minute timeout budget.