inline hostname resolution for remote sandbox config#19739
Merged
abhinav-oai merged 4 commits intomainfrom Apr 27, 2026
Merged
Conversation
abhinav-oai
force-pushed
the
abhinav/lazy-remote-sandbox-hostname
branch
from
26b1963 to
7def644
Compare
abhinav-oai
force-pushed
the
abhinav/lazy-remote-sandbox-hostname
branch
from
7def644 to
cdc42b2
Compare
abhinav-oai
changed the title
abhinav-oai
changed the title
This was referenced Apr 27, 2026
abhinav-oai
force-pushed
the
abhinav/lazy-remote-sandbox-hostname
branch
from
cdc42b2 to
b9b7d40
Compare
abhinav-oai
force-pushed
the
abhinav/lazy-remote-sandbox-hostname
branch
from
b9b7d40 to
4e2f477
Compare
abhinav-oai
commented
Apr 27, 2026
| ) { | ||
| requirements.apply_remote_sandbox_config(host_name); | ||
| if requirements.remote_sandbox_config.is_some() { | ||
| let host_name = crate::host_name(); |
Collaborator
Author
There was a problem hiding this comment.
basically just inlined it here
Collaborator
Author
|
@codex review |
abhinav-oai
changed the title
Contributor
|
Codex Review: Didn't find any major issues. What shall we delve into next? ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
etraut-openai
approved these changes
Apr 27, 2026
Collaborator
etraut-openai
left a comment
etraut-openai
left a comment
There was a problem hiding this comment.
Nice! This not only addresses the regression but also simplifies the code quite a bit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Requirements support host-specific
remote_sandbox_config.hostname_patterns, but config loading previously resolved and passed the system hostname through every config-loading path even when no requirements layer usedremote_sandbox_config. On machines where hostname lookup is slow, startup and app-server config reads paid for a feature that was not active.We only need the hostname when a requirements layer actually declares
remote_sandbox_config, so this moves hostname resolution to the single requirements merge point and keeps all other config callers unaware of hostname matching.What
host_nameplumbing fromload_config_layers_state,load_requirements_toml,ConfigBuilder, app-serverConfigManager, network proxy loading, and related call sites.merge_requirements_with_remote_sandbox_configonly when the incoming requirements containremote_sandbox_config.