Add hooks/list app-server RPC by abhinav-oai · Pull Request #19778 · openai/codex

abhinav-oai · 2026-04-27T06:04:08Z

Why

We need a way to list the available hooks to expose via the TUI and App so users can view and manage their hooks

What

Adds hooks/list for one or more cwd values that returns discovered hook metadata

Stack

Review Notes

The generated schema files account for most of the raw diff, these files have the core change:

hooks/src/engine/discovery.rs builds the inventory entries during hook discovery while leaving runtime handlers focused on execution.
app-server/src/codex_message_processor.rs wires hooks/list into the app-server flow for each requested cwd.
app-server-protocol/src/protocol/v2.rs defines the new v2 request/response payloads exposed on the wire.

Core Changes

core/src/plugins/manager.rs adds plugins_for_layer_stack(...) so skills/list and hooks/listcan resolve plugin state for each requested cwd

- anomalyco/opencode#24574 ignore: split up reasoning transforms (merge-as-is) - anomalyco/opencode#24573 fix: vertex anthropic toolStreaming default (merge-as-is) - openai/codex#19778 hooks/list + hooks/config/write APIs (merge-after-nits) - openai/codex#19772 permissions: derive config defaults as profiles (merge-after-nits)

Co-authored-by: Codex <noreply@openai.com>

…ry' into dev/abhinav/hooks-list-config # Conflicts: # codex-rs/app-server/src/codex_message_processor.rs

…oks-list-config

…ry' into dev/abhinav/hooks-list-config # Conflicts: # codex-rs/core-plugins/src/loader.rs # codex-rs/hooks/src/engine/discovery.rs

abhinav-oai · 2026-04-28T18:18:52Z

    configured_marketplace_upgrade_state: RwLock<ConfiguredMarketplaceUpgradeState>,
    non_curated_cache_refresh_state: RwLock<NonCuratedCacheRefreshState>,
-    cached_enabled_outcome: RwLock<Option<PluginLoadOutcome>>,
+    cached_enabled_outcome: RwLock<Option<(bool, PluginLoadOutcome)>>,


need this in case the flag changes, we can't return the same cached results

temporary while plugin_hooks is under development, will rip all this out once the safety + trust has landed

Can you add a comment suggesting the meaning of this bool so people don't need to read the code?

abhinav-oai · 2026-04-28T18:30:49Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 425cd2d72b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-04-28T18:40:52Z

+                )
+                .await;
+            let hooks = codex_hooks::list_hooks(codex_hooks::HooksConfig {
+                feature_enabled: config.features.enabled(Feature::CodexHooks),


Use per-cwd feature flags when listing hooks

hooks_list_response resolves a config layer stack for each requested cwd, but it gates plugin hooks and codex hooks using config.features loaded once before the loop. If different cwds have different feature settings (e.g. features.codex_hooks or features.plugin_hooks), the API returns incorrect hook inventories for non-primary paths.

Useful? React with 👍 / 👎.

I think codex is just getting tripped up by the naming

we check the features from the actual cwd that codex is running from

the cwds that get provided to hooks/list (also skills/list) is just a list of dirs to look for hooks.json files. we don't wanna respect any potential features in those dirs

## Why Plugins can bundle lifecycle hooks, but Codex previously only discovered hooks from user, project, and managed config layers. This adds the plugin discovery and runtime plumbing needed for plugin-bundled hooks while keeping execution behind the `plugin_hooks` feature flag. ## What - Discovers plugin hook sources from each plugin's default `hooks/hooks.json`. - Supports `plugin.json` manifest `hooks` entries as either relative paths or inline hook objects. - Plumbs discovered plugin hook sources through plugin loading into the hook runtime when `plugin_hooks` is enabled. - Marks plugin-originated hook runs as `HookSource::Plugin`. - Injects `PLUGIN_ROOT` and `CLAUDE_PLUGIN_ROOT` into plugin hook command environments. - Updates generated schemas and hook source metadata for the plugin hook source. ## Stack 1. This PR - #19705 2. #19778 3. #19840 4. #19882 ## Reviewer Notes - Core logic is in `codex-rs/core-plugins/src/loader.rs` and `codex-rs/hooks/src/engine/discovery.rs` - Moved existing / adding new tests to `codex-rs/core-plugins/src/loader_tests.rs` hence the large diff there - Otherwise mostly plumbing and minor schema updates ### Core Changes The `codex-rs/core` changes are limited to wiring plugin hook support into existing core flows: - `core/src/session/session.rs` conditionally pulls effective plugin hook sources and plugin hook load warnings from `PluginsManager` when `plugin_hooks` is enabled, then passes them into `HooksConfig`. - `core/src/hook_runtime.rs` adds the `plugin` metric tag for `HookSource::Plugin`. - `core/config.schema.json` picks up the new `plugin_hooks` feature flag, and `core/src/plugins/manager_tests.rs` updates fixtures for the added plugin hook fields. --------- Co-authored-by: Codex <noreply@openai.com>

…t-config # Conflicts: # codex-rs/app-server-protocol/schema/json/ClientRequest.json # codex-rs/core-plugins/src/loader.rs # codex-rs/hooks/src/engine/discovery.rs # codex-rs/hooks/src/engine/mod.rs

…t-config # Conflicts: # codex-rs/app-server-protocol/schema/json/ClientRequest.json # codex-rs/app-server-protocol/schema/json/codex_app_server_protocol.schemas.json # codex-rs/app-server-protocol/schema/json/codex_app_server_protocol.v2.schemas.json # codex-rs/app-server-protocol/schema/typescript/v2/index.ts # codex-rs/hooks/src/lib.rs

…nto dev/abhinav/hooks-list-config

eternal-openai · 2026-04-29T20:37:37Z

PR reads well! One minor concern. Can you pull on this thread:

hooks/list resolves a per-cwd ConfigLayerStack, but then uses a single process-global Config snapshot to decide plugins, plugin_hooks, and codex_hooks. If the app-server was started in repo A and the client asks for hooks in repo B, differing feature flags in B's .codex/config.toml are ignored: hooks can disappear when B enables them, or be exposed when B disables them. Because the RPC is explicitly multi-cwd, its enablement checks need to be derived from each requested cwd's effective config/layer stack.

So my understanding of this issue:

Start app-server while sitting in repo A
Repo A has .codex/config.toml with codex_hooks = false
Repo B has .codex/config.toml with codex_hooks = true, plus hooks configured
Call hooks/list for repo B

What happens now:

The RPC correctly loads repo B’s hook definitions via repo B’s ConfigLayerStack. Then it passes feature_enabled: config.features.enabled(Feature::CodexHooks) from the global config, which still reflects repo A

Result: hooks/list says “no hooks” for repo B

…t-config # Conflicts: # codex-rs/app-server/src/codex_message_processor.rs # codex-rs/core/src/plugins/manager.rs # codex-rs/core/src/session/handlers.rs

…t-config # Conflicts: # codex-rs/core/src/plugins/manager.rs

…nto dev/abhinav/hooks-list-config

abhinav-oai added 7 commits April 26, 2026 13:10

Discover hooks bundled with plugins

b2f2c98

Remove plugin hook load warnings from discovery

d2097f9

Refactor plugin hook file loading

6655134

Fix plugin hook test argument comment

5aed78a

Move plugin loader tests out of implementation

803c16f

Inline plugin hook relative path

108dc35

Add hook listing and config APIs

d5539f4

abhinav-oai and others added 3 commits April 27, 2026 09:38

Document hook config APIs

38c5e3a

Refactor plugin hook loader test assertions

6d03af7

Co-authored-by: Codex <noreply@openai.com>

Reduce hooks list PR to inventory only

06d95b2

abhinav-oai changed the title ~~Add hook listing and config APIs~~ Add hooks/list inventory API Apr 27, 2026

abhinav-oai mentioned this pull request Apr 27, 2026

Add persisted hook enablement state #19840

Merged

abhinav-oai added 5 commits April 27, 2026 11:25

Simplify shared cwd config loading

a6df152

Merge branch 'main' into dev/abhinav/plugin-hooks-discovery

50ed9a4

Merge remote-tracking branch 'origin/dev/abhinav/plugin-hooks-discove…

2c7a78c

…ry' into dev/abhinav/hooks-list-config # Conflicts: # codex-rs/app-server/src/codex_message_processor.rs

Merge branch 'main' into dev/abhinav/plugin-hooks-discovery

fbe0bf9

Merge branch 'dev/abhinav/plugin-hooks-discovery' into dev/abhinav/ho…

1c82afb

…oks-list-config

abhinav-oai changed the title ~~Add hooks/list inventory API~~ Add hooks/list app-server RPC Apr 27, 2026

Trim hooks list metadata

98efa54

abhinav-oai marked this pull request as ready for review April 28, 2026 00:02

abhinav-oai requested a review from a team as a code owner April 28, 2026 00:02

Gate plugin hook loading

85be136

abhinav-oai added the code-reviewed label Apr 28, 2026

abhinav-oai added 3 commits April 27, 2026 17:27

Simplify hooks list plumbing

e0ff2ad

Support plugin hook path substitution and data dirs

2c4c2c1

Merge remote-tracking branch 'origin/dev/abhinav/plugin-hooks-discove…

ef0f68b

…ry' into dev/abhinav/hooks-list-config # Conflicts: # codex-rs/core-plugins/src/loader.rs # codex-rs/hooks/src/engine/discovery.rs

This was referenced Apr 28, 2026

Discover hooks bundled with plugins #19705

Merged

Add /hooks browser for lifecycle hooks #19882

Merged

Fix plugin hook listing regressions

b9cd674

abhinav-oai added 3 commits April 28, 2026 10:43

Store plugin hook mode on load outcome

32ad9b1

Pass plugin hook flag through helper

b1b7450

Simplify hooks list plumbing

2b48f64

abhinav-oai commented Apr 28, 2026

View reviewed changes

Add hooks list plugin coverage

425cd2d

update comment

ef403b2

chatgpt-codex-connector Bot reviewed Apr 28, 2026

View reviewed changes

Simplify per-layer plugin loading

225940f

Base automatically changed from dev/abhinav/plugin-hooks-discovery to main April 28, 2026 21:17

abhinav-oai added 7 commits April 28, 2026 14:18

Clarify plugin hook cache key

95f931b

Merge remote-tracking branch 'origin/main' into dev/abhinav/hooks-lis…

02faa3b

…t-config # Conflicts: # codex-rs/app-server-protocol/schema/json/ClientRequest.json # codex-rs/core-plugins/src/loader.rs # codex-rs/hooks/src/engine/discovery.rs # codex-rs/hooks/src/engine/mod.rs

Merge branch 'main' into dev/abhinav/hooks-list-config

bfc222a

Merge branch 'main' into dev/abhinav/hooks-list-config

1e0b0bd

Merge remote-tracking branch 'origin/dev/abhinav/hooks-list-config' i…

b272bb1

…nto dev/abhinav/hooks-list-config

Merge branch 'main' into dev/abhinav/hooks-list-config

ca8e5d6

pakrym-oai approved these changes Apr 29, 2026

View reviewed changes

abhinav-oai added 2 commits April 29, 2026 14:31

Fix hooks list feature resolution per cwd

a3f8189

Merge remote-tracking branch 'origin/main' into dev/abhinav/hooks-lis…

3c6b3a0

…t-config # Conflicts: # codex-rs/app-server/src/codex_message_processor.rs # codex-rs/core/src/plugins/manager.rs # codex-rs/core/src/session/handlers.rs

abhinav-oai enabled auto-merge (squash) April 29, 2026 21:51

abhinav-oai added 3 commits April 29, 2026 15:11

Merge branch 'main' into dev/abhinav/hooks-list-config

c143e34

Merge remote-tracking branch 'origin/main' into dev/abhinav/hooks-lis…

ca6dbf2

…t-config # Conflicts: # codex-rs/core/src/plugins/manager.rs

Merge remote-tracking branch 'origin/dev/abhinav/hooks-list-config' i…

e2d6224

…nto dev/abhinav/hooks-list-config

abhinav-oai merged commit 8774229 into main Apr 29, 2026
34 of 36 checks passed

abhinav-oai deleted the dev/abhinav/hooks-list-config branch April 29, 2026 23:40

github-actions Bot locked and limited conversation to collaborators Apr 29, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add hooks/list app-server RPC#19778

Add hooks/list app-server RPC#19778
abhinav-oai merged 39 commits intomainfrom
dev/abhinav/hooks-list-config

abhinav-oai commented Apr 27, 2026 •

edited

Loading

Uh oh!

abhinav-oai Apr 28, 2026 •

edited

Loading

Uh oh!

xl-openai Apr 28, 2026

Uh oh!

abhinav-oai commented Apr 28, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Apr 28, 2026

Uh oh!

abhinav-oai Apr 28, 2026 •

edited

Loading

Uh oh!

eternal-openai commented Apr 29, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

abhinav-oai commented Apr 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why

What

Stack

Review Notes

Core Changes

Uh oh!

abhinav-oai Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

xl-openai Apr 28, 2026

Choose a reason for hiding this comment

Uh oh!

abhinav-oai commented Apr 28, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Apr 28, 2026

Choose a reason for hiding this comment

Uh oh!

abhinav-oai Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eternal-openai commented Apr 29, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

abhinav-oai commented Apr 27, 2026 •

edited

Loading

abhinav-oai Apr 28, 2026 •

edited

Loading

abhinav-oai Apr 28, 2026 •

edited

Loading