Skip to content

fix(network-proxy): tighten network proxy bypass defaults#20002

Merged
evawong-oai merged 1 commit intomainfrom
codex/viyatb/network-proxy-bypass-defaults
Apr 28, 2026
Merged

fix(network-proxy): tighten network proxy bypass defaults#20002
evawong-oai merged 1 commit intomainfrom
codex/viyatb/network-proxy-bypass-defaults

Conversation

@viyatb-oai
Copy link
Copy Markdown
Collaborator

@viyatb-oai viyatb-oai commented Apr 28, 2026

Why

Managed sessions use NO_PROXY to keep a small set of destinations on the direct path by default. The old default also bypassed all IPv4 link-local addresses in 169.254.0.0/16, which includes metadata endpoints such as 169.254.169.254. Because NO_PROXY is evaluated by the client before the request reaches the managed proxy, requests to that range could skip proxy-side allowlist and local-binding checks entirely. On hosts where a link-local metadata service is reachable, that creates a path to sensitive environment metadata or credentials outside the intended enforcement point.

What changed

  • remove the default IPv4 link-local 169.254.0.0/16 bypass from the managed proxy environment
  • keep the existing loopback and private-network defaults unchanged
  • update the regression assertion to lock in the narrower default

Security impact

Link-local requests now stay on the managed-proxy path by default, so the proxy can apply configured policy before they reach metadata-style endpoints or other link-local services.

Verification

  • cargo test -p codex-network-proxy

Co-authored-by: Codex <noreply@openai.com>
@viyatb-oai viyatb-oai changed the title [codex] Tighten network proxy bypass defaults fix(network-proxy): tighten network proxy bypass defaults Apr 28, 2026
@viyatb-oai viyatb-oai marked this pull request as ready for review April 28, 2026 16:19
Copy link
Copy Markdown
Contributor

@evawong-oai evawong-oai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evawong-oai evawong-oai merged commit 3afb185 into main Apr 28, 2026
25 of 26 checks passed
@evawong-oai evawong-oai deleted the codex/viyatb/network-proxy-bypass-defaults branch April 28, 2026 17:51
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 28, 2026
@evawong-oai
Copy link
Copy Markdown
Contributor

evawong-oai commented Apr 28, 2026

Validation I ran before merge:

  1. Confirmed this maps to the link local proxy bypass item in the readiness tracker.
  2. Reviewed the proxy default bypass list and confirmed 169.254.0.0/16 was removed from DEFAULT_NO_PROXY_VALUE.
  3. Confirmed the change means link local IMDS requests are no longer silently excluded from proxy policy by the default no proxy list.
  4. Verified required GitHub checks were green before merge.
  5. Ran the targeted network proxy validation locally and confirmed the relevant tests passed.
  6. Recorded the merged commit 3afb185 in the readiness tracker.

Remaining readiness gate: verify the target event build includes this commit and validate link local IMDS requests route through proxy policy with allow_local_binding false.

Ship decision: approved and merged as the minimal fix. I updated the readiness row to Closed but Verify.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants