fix(network-proxy): tighten network proxy bypass defaults#20002
Merged
evawong-oai merged 1 commit intomainfrom Apr 28, 2026
Merged
fix(network-proxy): tighten network proxy bypass defaults#20002evawong-oai merged 1 commit intomainfrom
evawong-oai merged 1 commit intomainfrom
Conversation
Co-authored-by: Codex <noreply@openai.com>
Contributor
|
Validation I ran before merge:
Remaining readiness gate: verify the target event build includes this commit and validate link local IMDS requests route through proxy policy with allow_local_binding false. Ship decision: approved and merged as the minimal fix. I updated the readiness row to Closed but Verify. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Managed sessions use
NO_PROXYto keep a small set of destinations on the direct path by default. The old default also bypassed all IPv4 link-local addresses in169.254.0.0/16, which includes metadata endpoints such as169.254.169.254. BecauseNO_PROXYis evaluated by the client before the request reaches the managed proxy, requests to that range could skip proxy-side allowlist and local-binding checks entirely. On hosts where a link-local metadata service is reachable, that creates a path to sensitive environment metadata or credentials outside the intended enforcement point.What changed
169.254.0.0/16bypass from the managed proxy environmentSecurity impact
Link-local requests now stay on the managed-proxy path by default, so the proxy can apply configured policy before they reach metadata-style endpoints or other link-local services.
Verification
cargo test -p codex-network-proxy