Skip to content

codex: route metadata updates through ThreadStore#20576

Merged
wiltzius-openai merged 1 commit into
mainfrom
wiltzius/codex/thread-store-live-metadata
May 5, 2026
Merged

codex: route metadata updates through ThreadStore#20576
wiltzius-openai merged 1 commit into
mainfrom
wiltzius/codex/thread-store-live-metadata

Conversation

@wiltzius-openai
Copy link
Copy Markdown
Contributor

@wiltzius-openai wiltzius-openai commented May 1, 2026

  • Route thread/metadata/update through ThreadStore::update_thread_metadata.
  • Add LocalThreadStore git metadata patch support for set, partial update, and clear semantics.
  • Add some unit tests for the new thread store code
  • Remove a lot of dead code/tests!

@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-live-metadata branch 3 times, most recently from 0f98012 to 96ff4cf Compare May 1, 2026 17:15
Base automatically changed from wiltzius/codex/thread-read-store-history to main May 1, 2026 17:55
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-live-metadata branch 2 times, most recently from 66a3536 to 072f991 Compare May 1, 2026 18:47
@wiltzius-openai wiltzius-openai changed the title codex: add store-backed live thread metadata helpers codex: support git metadata patches in LocalThreadStore May 1, 2026
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-live-metadata branch 4 times, most recently from 1e07b6d to c0e1485 Compare May 1, 2026 21:05
@wiltzius-openai wiltzius-openai changed the title codex: support git metadata patches in LocalThreadStore codex: route git metadata updates through ThreadStore May 1, 2026
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-live-metadata branch 3 times, most recently from 07ddf88 to b6e887d Compare May 1, 2026 22:07
@wiltzius-openai wiltzius-openai marked this pull request as ready for review May 1, 2026 22:08
@wiltzius-openai wiltzius-openai requested a review from a team as a code owner May 1, 2026 22:08
Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b6e887d52f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/thread-store/src/local/update_thread_metadata.rs Outdated
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-live-metadata branch 7 times, most recently from d87b44c to 1bc9368 Compare May 1, 2026 23:38
@wiltzius-openai
Copy link
Copy Markdown
Contributor Author

@codex review

@wiltzius-openai wiltzius-openai changed the title codex: route git metadata updates through ThreadStore codex: route metadata updates through ThreadStore May 1, 2026
Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1bc9368afa

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/thread-store/src/local/update_thread_metadata.rs
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-live-metadata branch from 1bc9368 to 7e94adc Compare May 1, 2026 23:50
Comment thread codex-rs/app-server/src/codex_message_processor.rs Outdated
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-live-metadata branch from 7e94adc to 4b98af1 Compare May 4, 2026 22:49
Comment thread codex-rs/app-server/src/codex_message_processor.rs Outdated
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-live-metadata branch 2 times, most recently from b1ac602 to fdef4ce Compare May 4, 2026 23:54
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-live-metadata branch from fdef4ce to 7e67257 Compare May 5, 2026 00:19
@wiltzius-openai wiltzius-openai merged commit 707e51b into main May 5, 2026
37 of 38 checks passed
@wiltzius-openai wiltzius-openai deleted the wiltzius/codex/thread-store-live-metadata branch May 5, 2026 03:09
@github-actions github-actions Bot locked and limited conversation to collaborators May 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants