Conversation
starr-openai
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#20585 moved the Windows Bazel test job to the cross-compile path, but the Windows Bazel clippy and verify-release-build jobs were still using the native Windows/MSVC-host fallback. Those two jobs became the slowest Windows PR legs, even though both are build-only signal and do not need to execute the resulting binaries.
What Changed
--windows-msvc-host-platformto--windows-cross-compile, so clippy build actions use Linux RBE while still targetingx86_64-pc-windows-gnullvm.--windows-cross-compileas well. This job only compilescfg(not(debug_assertions))Rust code underfastbuild, so it does not need a native Windows build host.--skip_incompatible_explicit_targetsbehavior only for fork/community PRs withoutBUILDBUDDY_API_KEY, whererun-bazel-ci.shfalls back to the local Windows MSVC-host shape.--windows-cross-compilesupport to.github/scripts/run-bazel-query-ci.sh, so target-discovery queries select the sameci-windows-crossconfig as the subsequent build.scripts/list-bazel-clippy-targets.shso the Windows clippy job discovers targets under the same platform shape as the subsequent clippy build.Verification
Local checks:
The Linux target-list check reported
0Windows-cross internal test binaries, while the Windows cross target-list check reported47, preserving the test-code clippy coverage shape from the existing Windows job.