Skip to content

[codex] Split app-server request processors#20940

Merged
pakrym-oai merged 1 commit into
mainfrom
pakrym/mechanical-message-processors
May 4, 2026
Merged

[codex] Split app-server request processors#20940
pakrym-oai merged 1 commit into
mainfrom
pakrym/mechanical-message-processors

Conversation

@pakrym-oai
Copy link
Copy Markdown
Collaborator

Why

The app-server request path had grown around a large CodexMessageProcessor plus separate API wrapper/helper modules. That made the dependency graph hard to see and forced unrelated request families to share broad processor state.

This PR makes the split mechanical and command-prefix oriented so request families own only the dependencies they use.

What changed

  • Replaced CodexMessageProcessor with command-prefix request processors under app-server/src/request_processors/.
  • Removed the old config, device-key, external-agent-config, and fs API wrapper files by moving their API handling into processors.
  • Split apps, plugins, marketplace, catalog, account, MCP, command exec, fs, git, feedback, thread, turn, thread goals, and Windows sandbox handling into dedicated processors.
  • Kept shared lifecycle, summary conversion, token usage replay, and shared error mapping only where multiple processors use them; single-use helpers were inlined into their owning processor.
  • Removed the fallback processor path and moved processor tests to _tests files.

Validation

  • cargo test -p codex-app-server
  • cargo check -p codex-app-server
  • just fix -p codex-app-server

@pakrym-oai pakrym-oai force-pushed the pakrym/mechanical-message-processors branch from 4125857 to 84d6dfd Compare May 4, 2026 05:51
@pakrym-oai pakrym-oai force-pushed the pakrym/mechanical-message-processors branch from 84d6dfd to 96b5b6b Compare May 4, 2026 06:00
@pakrym-oai pakrym-oai marked this pull request as ready for review May 4, 2026 16:22
@pakrym-oai pakrym-oai merged commit 33b19bc into main May 4, 2026
26 checks passed
@pakrym-oai pakrym-oai deleted the pakrym/mechanical-message-processors branch May 4, 2026 16:34
@github-actions github-actions Bot locked and limited conversation to collaborators May 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants