memories-mcp: reject symlink traversal in local backend#21010
Merged
Conversation
Collaborator
Author
|
@codex review |
Contributor
|
Codex Review: Didn't find any major issues. Bravo. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The local memories MCP backend only rejected symlinks after resolving the final path. That left room for scoped requests like
skills/secret.mdto walk through a symlinked ancestor directory and escape the configured memories root.This change also makes missing scoped paths fail explicitly instead of looking like an empty
list/searchresult or aNotFileread error.What Changed
LocalMemoriesBackend::resolve_scoped_pathand reject symlinked ancestors before accessing the targetNotFoundbackend error for missingread,list, andsearchpaths and map it through the MCP server error conversioncodex-rs/memories/mcp/src/local_tests.rsTesting
codex-rs/memories/mcp/src/local_tests.rsfor missing paths and symlinked ancestor directories acrossread,list, andsearch