Skip to content

Auto-deny MCP elicitations for Xcode 26.4 clients#21113

Merged
etraut-openai merged 2 commits into
mainfrom
etraut/xcode-mcp-elicitation-lean-experiment
May 5, 2026
Merged

Auto-deny MCP elicitations for Xcode 26.4 clients#21113
etraut-openai merged 2 commits into
mainfrom
etraut/xcode-mcp-elicitation-lean-experiment

Conversation

@etraut-openai
Copy link
Copy Markdown
Collaborator

Summary

Xcode 26.4 was built against app-server behavior from before MCP elicitation requests became client-visible in CLI 0.120.0 via #17043. That client line does not expect the new events/messages, so this PR restores the old behavior for exactly that client/version combination.

The compatibility handling stays in the app-server layer: when the initialized client is Xcode and its version starts with 26.4, the app server marks the live Codex thread so MCP elicitations are auto-denied. The flag is applied on thread start/resume/fork/turn attachment, carried through Codex/CodexThread, and stored on McpConnectionManager so refreshed MCP managers preserve the behavior.

Notes

This is intentionally narrow and includes a TODO to remove the compatibility path once Xcode 26.4 ages out.

@etraut-openai etraut-openai requested a review from a team as a code owner May 5, 2026 00:04
Copy link
Copy Markdown
Collaborator

@mzeng-openai mzeng-openai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the compatibility path and this looks good to land from my side.

@etraut-openai etraut-openai merged commit 8c88f9a into main May 5, 2026
26 checks passed
@etraut-openai etraut-openai deleted the etraut/xcode-mcp-elicitation-lean-experiment branch May 5, 2026 21:05
@github-actions github-actions Bot locked and limited conversation to collaborators May 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants