app-server: refresh live threads from latest config snapshot#21187
Conversation
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
refresh_runtime_config on Codex threadThere was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ad56d24eda
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-authored-by: Codex <noreply@openai.com>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 85fe8faa83
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-authored-by: Codex <noreply@openai.com>
Why
App-server config writes were leaving existing threads partially stale. After a config mutation, the app-server told each live thread to run
Op::ReloadUserConfig, but that path only re-read the userconfig.tomllayer. Settings that came from the app-server's materialized config snapshot did not propagate to existing threads until restart.This change prevent a FS access from
corefor CCA.What changed
CodexThread::refresh_runtime_config()andSession::refresh_runtime_config()so the app-server can push a freshly rebuilt config snapshot into a live threadcwdafter config mutations, then refresh the thread from that snapshot instead of asking it to reload onlyconfig.tomltool_suggest, and derived hook/plugin/skill statereload_user_config_layer()as the file-backed fallback for legacy local reload flows, but route the shared refresh logic through the new runtime refresh pathTesting
refresh_runtime_config()rebuilds hooks from refreshed configmodelandnotifystay unchanged